Federico Simoncelli has uploaded a new change for review.
Change subject: Uniform the block and file volume methods ......................................................................
Uniform the block and file volume methods
In this patch: * Consistent use of metaId to identify the volume metadata * Use the same arguments for halfbakedVolumeRollback in file and block domains (backward compatible with the previous format) * Few changes and cleanup to comply to PEP8
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef --- M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/volume.py 3 files changed, 106 insertions(+), 100 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/3683/1 -- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 1: (1 inline comment)
Fix my comment only if you are going to resubmit anyway.
.................................................... File vdsm/storage/blockVolume.py Line 142: cls.log.info("createVolumeMetadataRollback: " No need to put the name of the function, it is already done by the log formatter.
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Just minor comments from me and Saggi
.................................................... File vdsm/storage/fileVolume.py Line 95: cls.log.info("halfbakedVolumeRollback: volPath=%s" % (volPath)) No need function name + change % with ,
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/storage/fileVolume.py Line 363: return (self.getVolumePath(),) Hmmm, it's looks odd that getMetadataId() returns volume path. Maybe you meant metadata volume path ?
Line 374: sorry man, it's look a little mess here. The previous code was pretty simple, why you changed it?
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 4: (2 inline comments)
.................................................... File vdsm/storage/fileVolume.py Line 363: return (self.getVolumePath(),) You don't care what getMetadataId returns. It's meant to return some internal data that the Volume class uses to identify where the metadata is. In the block domains the id is the (sdUUID, offset), and in the file domains it's simply the volume path (volPath,). You're not supposed to look into it, it's some internal data used by the Volume subclasses when they need to deal with the metadata.
Line 374: I can't see the mess other than the mess that was already there :-) Now getMetadata is transparent both in file and block domains (it uses the metaId). The mess starts when for some reason we need to support also the previous behavior for vol_path=None which doesn't make sense (eg: why do you use *this* volume object to read some *other* volume metadata???)
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 4: (3 inline comments)
.................................................... File vdsm/storage/fileVolume.py Line 363: return (self.getVolumePath(),) hmmm, OK
Line 374: Ah, OK, Fine, Good. :) Don't be so gentle ;)
Line 446: sanlock.init_resource(sdUUID, volUUID, [(leasePath, 0)]) I don't know why you decided to remove LEASE_FILEOFFSET. But if you decided so, the question whether we need its defintion above?
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 7: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 21: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 21: Looks good to me, approved
(1 inline comment)
Please note inline comment
.................................................... File vdsm/storage/blockVolume.py Line 290: if mysd.hasVolumeLeases(): this is to initialize the lease. is there any problem doing this on a V1/V2 SD? if not, would that matter when upgrading the domain? (make upgrade faster perhaps?) if it makes no difference or even improves things then I wouldn't limit this to V3 domains.
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 21: (1 inline comment)
.................................................... File vdsm/storage/blockVolume.py Line 290: if mysd.hasVolumeLeases(): Done
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 22: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 23: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 23: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/blockVolume.py Line 674: return (self.sdUUID, self.getMetaOffset()) Why do you return the sdUUID? Seems highly irregular
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 23: (1 inline comment)
.................................................... File vdsm/storage/blockVolume.py Line 674: return (self.sdUUID, self.getMetaOffset()) Why? What did you expect here? All the BlockVolume methods were using the sdUUID and the offset to identify the metadata. Here I'm just making it explicit. Anyway this is an internal opaque object (only BlockVolume knows what it represents).
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 23: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 23: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 23: Verified
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 25: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 25: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods ......................................................................
Patch Set 25: Verified
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Uniform the block and file volume methods ......................................................................
Uniform the block and file volume methods
In this patch: * Consistent use of metaId to identify the volume metadata * Use the same arguments for halfbakedVolumeRollback in file and block domains (backward compatible with the previous format) * Few changes and cleanup to comply to PEP8
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef --- M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/volume.py 3 files changed, 139 insertions(+), 105 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/3683 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ib945853e68f6a4562668468c7a24d218c4921cef Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org