12:11 p.m.
New patch submitted by Federico Simoncelli (fsimonce(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/924
commit 5c34b8a2b26533c19a336acd934054bc9254f02f
Author: Federico Simoncelli <fsimonce(a)redhat.com>
Date: Fri Sep 9 17:01:26 2011 +0000
BZ#733669 Return specific error for invalid host
Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 3dde1c0..fdc401b 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -778,7 +778,7 @@ class clientIF:
if not utils.validLocalHostname():
self.log.error('Migration failed: local hostname is not correct')
- return errCode['createErr']
+ return errCode['wrongHost']
response = self.create(params)
if response['status']['code']:
diff --git a/vdsm/define.py b/vdsm/define.py
index ca30ddf..78e7563 100644
--- a/vdsm/define.py
+++ b/vdsm/define.py
@@ -36,6 +36,7 @@ errCode = { 'noVM': {'status': {'code':
1, 'message': 'Virtual machine d
'ticketErr': {'status': {'code':18,
'message': 'Error while setting spice ticket'}},
'nonresp': {'status': {'code':19,
'message': 'Guest agent non-responsive'}},
# codes 20-29 are reserved for add/delNetwork
+ 'wrongHost': {'status': {'code':39,
'message': 'Migration destination has an invalid hostname'}},
'unavail': {'status': {'code':40,
'message': 'Resource unavailable'}},
'changeDisk': {'status': {'code':41,
'message': 'Failed to change disk image'}},
'destroyErr': {'status': {'code':42,
'message': 'Virtual machine destroy error'}},
7:08 a.m.
New subject: Change in vdsm[master]: BZ#733669 Return specific error for invalid host
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Return specific error for invalid host
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
sorry you had to take the errcode up the stack...
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
9:09 a.m.
New subject: Change in vdsm[master]: BZ#733669 Return specific error for invalid host
Federico Simoncelli has posted comments on this change.
Change subject: BZ#733669 Return specific error for invalid host
......................................................................
Patch Set 3:
Waiting verification:
https://trac.qa.lab.tlv.redhat.com/trac/integration/ticket/445
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:54 a.m.
New subject: Change in vdsm[master]: BZ#733669 Improve error reporting for wrong local hostname
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
BZ#733669 Improve error reporting for wrong local hostname
This patch improves the error reporting when migration fails.
It is mainly designed to return the new error 'wrongHost' to
the manager when the migration destination has a wrong local
hostname (which will cause the migration to fail without any
informative message).
Additionally it checks the local hostname during the bootstrap
process and produces a warning if needed.
In this patch:
* add local hostname check during bootstrap (report a warning)
* return the new error 'wrongHost' if migration destination has
a wrong local hostname
* source node must return a specific error when migration fails
Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
---
M vds_bootstrap/vds_bootstrap.py
M vdsm/clientIF.py
M vdsm/define.py
M vdsm/libvirtvm.py
M vdsm/vm.py
5 files changed, 43 insertions(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
David Naori: Verified
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:54 a.m.
New subject: Change in vdsm[master]: BZ#733669 Improve error reporting for wrong local hostname
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
Patch Set 9: Looks good to me, approved
could've been nicer to filer 'lo' device, but this is a nit.
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:41 a.m.
New subject: Change in vdsm[master]: BZ#733669 Improve error reporting for wrong local hostname
David Naori has posted comments on this change.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
Patch Set 9: Verified
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:16 a.m.
New subject: Change in vdsm[master]: BZ#733669 Improve error reporting for wrong local hostname
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 612: localip = None
oh, I missed that. but I still think that logging would be nice here. don't you?
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3:58 p.m.
New subject: Change in vdsm[master]: BZ#733669 Improve error reporting for wrong local hostname
Federico Simoncelli has posted comments on this change.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 612: localip = None
(fqdnip in localip) can't explode because "or" is a short-circuit operator
and I'm checking (localip is None).
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
3:08 p.m.
New subject: Change in vdsm[master]: BZ#733669 Improve error reporting for wrong local hostname
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 612: localip = None
better have localip = (), or (fqdnip in localip) would explode.
I know it's not your fault, but let's at least log all exc_info here and below.
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
10:05 a.m.
New subject: Change in vdsm[master]: BZ#733669 Improve error reporting for wrong local hostname
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Improve error reporting for wrong local hostname
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 608:
you are going to kill me for not thinking of this before...
but bootstrap code is so fragile and broken, that if ANYTHING here raises an exception, it
would not be caught at reported to rhevm. is there any chance we'll see an exception
here? if so, we'd better wrap this in try-except like everywhere else in this y*cky
file.
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12:32 a.m.
New subject: Change in vdsm[master]: BZ#733669 Return specific error for invalid host
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Return specific error for invalid host
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
Commit Message
Line 7: BZ#733669 Return specific error for invalid host
Sorry for only noticing this now, but the commit message is not good enough for a piece of
code we would like to revert when we start using virDomainMigrateToURI2. (well, almost
revert. I'd like to keep the bubbling of the error code)
Please describe the problem at had, and mention that this restriction is to be dropped
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
2:59 a.m.
New subject: Change in vdsm[master]: BZ#733669 Return specific error for invalid host
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Return specific error for invalid host
......................................................................
Patch Set 1: I would prefer that you didn't submit this
unfortunately, that's not enough to relay this information into migrateStatus() verb
on the source.
--
To view, visit http://gerrit.usersys.redhat.com/924
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
4657
days inactive
4663
days old
vdsm-patches@lists.fedorahosted.org
11 comments
3 participants
participants (3)
-
Dan Kenigsberg -
David Naori -
Federico Simoncelli