Change in vdsm[master]: getServices returns wrong order for depended services for li...

Yaniv Bronhaim has uploaded a new change for review.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

getServices returns wrong order for depended services for libvirt module

Configure verb runs over getServices returned list and stop those
services, configure vdsm, and start them in reverse order. In this patch
I fix current order which starts vdsm before supervdsmd service

Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/28818/1

diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index c8373fb..da05931 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -101,7 +101,7 @@
         return self.FILES[fname]['path']

def getServices(self):
-        return ["supervdsmd", "vdsmd", "libvirtd"]
+        return ["vdsmd", "supervdsmd", "libvirtd"]

def configure(self):
         if os.getuid() != 0:

Yaniv Bronhaim has posted comments on this change.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

Patch Set 1: Verified+1

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

Patch Set 1:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9327/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10111/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10267/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5193/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3351/ : SUCCESS

Antoni Segura Puimedon has posted comments on this change.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

Patch Set 1: Code-Review+1

mooli tayer has posted comments on this change.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

Patch Set 1: Code-Review+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

Patch Set 1: Code-Review+2

Raising score

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

getServices returns wrong order for depended services for libvirt module

Configure verb runs over getServices returned list and stop those
services, configure vdsm, and start them in reverse order. In this patch
I fix current order which starts vdsm before supervdsmd service

Change-Id: If8aba9ebdacc16e3af8153fb44360d3c4537e362
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: http://gerrit.ovirt.org/28818
Reviewed-by: Antoni Segura Puimedon 
Reviewed-by: mooli tayer 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  mooli tayer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getServices returns wrong order for depended services for libvirt module
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1485/ : SUCCESS