10:18 a.m.
Allon Mureinik has uploaded a new change for review.
Change subject: WIP: sd.py: Remove sds from sdCache when connecting
......................................................................
WIP: sd.py: Remove sds from sdCache when connecting
When connecting to a storage server, pre-existing domains should be
removed, since we have no way of knowing what happened to these
domains in the meanwhile.
Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950055
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/19995/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index d46ef50..8fae844 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2371,6 +2371,11 @@
self.log.debug("prefetch failed: %s",
sdCache.knownSDs, exc_info=True)
else:
+ # Any pre-existing domains in sdCache stand the chance of
+ # being invalid, since there is no way to know what happens
+ # to them while the storage is disconnected.
+ for sdUUID in doms.iterkeys():
+ sdCache.manuallyRemoveDomain(sdUUID)
sdCache.knownSDs.update(doms)
self.log.debug("knownSDs: {%s}", ", ".join("%s:
%s.%s" %
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
1:59 p.m.
New subject: Change in vdsm[master]: sd.py: Remove sds from sdCache when connecting
Federico Simoncelli has submitted this change and it was merged.
Change subject: sd.py: Remove sds from sdCache when connecting
......................................................................
sd.py: Remove sds from sdCache when connecting
When connecting to a storage server, pre-existing domains should be
removed, since we have no way of knowing what happened to these
domains in the meanwhile.
Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950055
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/19995
Reviewed-by: Ayal Baron <abaron(a)redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Ayal Baron: Looks good to me, approved
Federico Simoncelli: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:34 a.m.
New subject: Change in vdsm[master]: sd.py: Remove sds from sdCache when connecting
Allon Mureinik has posted comments on this change.
Change subject: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 2:
If all the reviewers think that http://gerrit.ovirt.org/#/c/18458/ is better, I don't
mind resurrecting it.
Note that it was never verified properly (only tested on SPM - my bad, as noted there),
but if that's the direction we're going, I'd happily reverify it.
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
5:22 a.m.
New subject: Change in vdsm[master]: sd.py: Remove sds from sdCache when connecting
Federico Simoncelli has posted comments on this change.
Change subject: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 2: Code-Review+2
Fine by me even though this solution is inferior to what was proposed in
http://gerrit.ovirt.org/#/c/18458/ (see Ayal's comment) Dan what's your take on
this?
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:45 a.m.
New subject: Change in vdsm[master]: sd.py: Remove sds from sdCache when connecting
Ayal Baron has posted comments on this change.
Change subject: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 2: Code-Review+2
I just discussed this with Federico and the truth is the original patch seems better since
it also solves any problems with FC domains.
The flow is that user activates the domain in engine:
this calls activateStorageDomain on SPM and then calls refreshStoragePool on all the
HSMs.
refreshStoragePool already removes the domains from the cache (since we got a hint that
something changed and we need to refresh it) and activateStorageDomain should not assume
the object is ok since up until now the domain was not active, i.e. we haven't been
monitoring it and it may have changed etc.
The flow in engine of activate is:
connectStorageServer (on spm) - not called in case of FC
activateSD
connectStorageServer (on all hosts) - not called in case of FC
refreshStoragePool
The previous patch was (imo wrongly) nack'd by Edu.
I'm acking this one, but I would really prefer the original one.
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:25 a.m.
New subject: Change in vdsm[master]: sd.py: Remove sds from sdCache when connecting
Allon Mureinik has posted comments on this change.
Change subject: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 2: Verified+1
Returning verified flag as above - just removed the "WIP" from the commit msg.
Note that the original patch had -1 from Eduardo and +2 from Ayal.
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:20 a.m.
Ayal Baron has posted comments on this change.
Change subject: WIP: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 1: Code-Review+2
Our purpose in this patch is to stabilize oVirt 3.3.
Eduardo's suggestion of removing the domain path from the domain object would be
anything but that, so although long term we should strive in that direction, in order to
correct current flows without introducing to much risk we need to do something minimal.
Wrt FC domains, although technically correct that this change would not hold for such
domains, the problematic use cases that have been found (see both the bz and the closed
duplicate of it) are around editing connections which by definition does not apply to FC
domains.
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
1:37 p.m.
Eduardo has posted comments on this change.
Change subject: WIP: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 1: Code-Review-1
connectStorageServer calls for FC by engine is required.
A solution for this (and other) BZ(s) should be not merged before.
The path to the SD should not be storaged in the SD cache.
This is a semantic error, in spite that is the actual semantics.
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:21 a.m.
Allon Mureinik has posted comments on this change.
Change subject: WIP: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 1: Verified+1
This is the solution suggested by Federico on comment 7 of the BZ.
Verified by creating a symlink to a domain's folder, moving to maintenance, editing
the domain's connection via engine's GUI and activating agin, both in SPM and
HSM.
Does this make sense to you guys?
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:21 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4764/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4840/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3955/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:25 a.m.
New subject: Change in vdsm[master]: sd.py: Remove sds from sdCache when connecting
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd.py: Remove sds from sdCache when connecting
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4779/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4855/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3970/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3881
days inactive
3889
days old
vdsm-patches@lists.fedorahosted.org
10 comments
5 participants
participants (5)
-
abaron＠redhat.com -
Allon Mureinik -
ewarszaw＠redhat.com -
Federico Simoncelli -
Jenkins CI RO