11:19 a.m.
Federico Simoncelli has uploaded a new change for review.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Move the SANLock SDM lease to a different offset
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I45db6790acffecfda006b513b784f8138605ad81
---
M vdsm/storage/safelease.py
1 file changed, 13 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/3840/1
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
3:07 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 17: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:29 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Move the SANLock SDM lease to a different offset
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I45db6790acffecfda006b513b784f8138605ad81
---
M vdsm/storage/blockVolume.py
M vdsm/storage/safelease.py
2 files changed, 17 insertions(+), 7 deletions(-)
Approvals:
Haim Ateya: Verified
Federico Simoncelli: Looks good to me, approved
Dan Kenigsberg:
Maor Lipchuk: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
1:03 p.m.
Haim Ateya has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 17: Verified
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
8:27 a.m.
Maor Lipchuk has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
2:54 p.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 16: (2 inline comments)
....................................................
File vdsm/storage/safelease.py
Line 37: # orfer to preserve the ability to acquire both locks (e.g.: during the
orfer->order
Line 40: SDM_LEASE_OFFSET = 512 * 2048
where does this number come from? what limitations does it put on MAX_HOST_ID ?
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:10 a.m.
Allon Mureinik has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 16: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
9:02 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 15: (1 inline comment)
....................................................
File vdsm/storage/safelease.py
Line 35:
Done
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
3:32 a.m.
Allon Mureinik has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 15: Looks good to me, but someone else must approve
(1 inline comment)
looks good, but please fix the comment.
....................................................
File vdsm/storage/safelease.py
Line 35:
grammer:
"in order to being able to acquire both locks (eg: during the domain upgrade)"
->
"in order to preserve the ability to acquire both locks (e.g.: during the domain
upgrade)"
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
10:06 a.m.
Maor Lipchuk has posted comments on this change.
Change subject: Move the SANLock SDM lease to a different offset
......................................................................
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45db6790acffecfda006b513b784f8138605ad81
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
4347
days inactive
4406
days old
vdsm-patches@lists.fedorahosted.org
9 comments
5 participants
participants (5)
-
Allon Mureinik -
Dan Kenigsberg -
Federico Simoncelli -
Haim Ateya -
Maor Lipchuk