Dan Kenigsberg has uploaded a new change for review.
Change subject: hooks: avoid redundant temporary list ......................................................................
hooks: avoid redundant temporary list
No functional change is expected.
Change-Id: Id6b0505ebabef0ec33a738c3698dc446e8849a2a Signed-off-by: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/hooks.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/65273/1
diff --git a/lib/vdsm/hooks.py b/lib/vdsm/hooks.py index 96969fd..777b4ee 100644 --- a/lib/vdsm/hooks.py +++ b/lib/vdsm/hooks.py @@ -453,8 +453,8 @@
def _getHookInfo(dir): - return dict([(os.path.basename(script), _getScriptInfo(script)) - for script in _scriptsPerDir(dir)]) + return dict((os.path.basename(script), _getScriptInfo(script)) + for script in _scriptsPerDir(dir))
def installed():
gerrit-hooks has posted comments on this change.
Change subject: hooks: avoid redundant temporary list ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: avoid redundant temporary list ......................................................................
Patch Set 1: Verified+1
function covered by unit tests
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: avoid redundant temporary list ......................................................................
Patch Set 1: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: avoid redundant temporary list ......................................................................
hooks: avoid redundant temporary list
No functional change is expected.
Change-Id: Id6b0505ebabef0ec33a738c3698dc446e8849a2a Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: https://gerrit.ovirt.org/65273 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski piotr.kliczewski@gmail.com --- M lib/vdsm/hooks.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified
gerrit-hooks has posted comments on this change.
Change subject: hooks: avoid redundant temporary list ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org