Change in vdsm[master]: Fix getCmdArgs() failing on some hosts

Saggi Mizrahi has uploaded a new change for review.

Change subject: Fix getCmdArgs() failing on some hosts
......................................................................

Fix getCmdArgs() failing on some hosts

Change-Id: Id06b03192f065d975c078e865e8514441e81450c
Signed-off-by: Saggi Mizrahi 
---
M vdsm/storage/misc.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/8974/1

diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index 426d181..945e3b2 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -1068,7 +1068,7 @@

def getCmdArgs(pid):
     with open("/proc/%d/cmdline" % pid, "r") as f:
-        return tuple(f.readline().split("\0")[:-1])
+        return tuple(f.read().split("\0")[:-1])

def pidStat(pid):

--
To view, visit http://gerrit.ovirt.org/8974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id06b03192f065d975c078e865e8514441e81450c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix getCmdArgs() failing on some hosts
......................................................................

Patch Set 1: Verified; Looks good to me, approved

how have I missed that readline? I have no idea how it causes the test failures, but it sure breaks getCmdArgs() when there are args with "\n".

--
To view, visit http://gerrit.ovirt.org/8974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id06b03192f065d975c078e865e8514441e81450c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix getCmdArgs() failing on some hosts
......................................................................

Fix getCmdArgs() failing on some hosts

Change-Id: Id06b03192f065d975c078e865e8514441e81450c
Signed-off-by: Saggi Mizrahi 
---
M vdsm/storage/misc.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/8974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id06b03192f065d975c078e865e8514441e81450c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix getCmdArgs() failing on some hosts
......................................................................

Patch Set 2:

quoting myself:
> I have no idea how it causes the test failures...

and indeed, this test's failure are still with us :-(

--
To view, visit http://gerrit.ovirt.org/8974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id06b03192f065d975c078e865e8514441e81450c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg