Change in vdsm[master]: Fix race during VM recovery flow

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Fix race during VM recovery flow
......................................................................

Fix race during VM recovery flow

In this patch:
* Save conf just after build devices
* Add identifier ID and __eq__ to Drive and NIC devices.

Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
---
M vdsm/libvirtvm.py
1 file changed, 30 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/1174/1
--
To view, visit http://gerrit.ovirt.org/1174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix race during VM recovery flow
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 11: * Add identifier ID and __eq__ to Drive and NIC devices.
and a few other changes. I'm confused. could you separate the race-fixing form the rest? (we may want to backport!)

--
To view, visit http://gerrit.ovirt.org/1174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg

Saggi Mizrahi has posted comments on this change.

Change subject: Fix race during VM recovery flow
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 926:     def __eq__(self, other):
Validate type, otherwise any object with ID could be compared

--
To view, visit http://gerrit.ovirt.org/1174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Fix race during VM recovery flow
......................................................................

Patch Set 1: (3 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 927:         return self.ID == other.ID
The kind of comparison that I need is more complex. Sadly this is not going to help me. Anyway I already implemented it in my patch, so as far as concern my problem you can remove both ID(self) and __eq__.

Line 1017:         return self.ID == other.ID
As above.

Line 1697:                     dev['name'] = name
Nice, thas is what I needed. I stole it for my http://gerrit.ovirt.org/469
If you're able to push this change before me I'll rebase my patch. Thanks Igor!

--
To view, visit http://gerrit.ovirt.org/1174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix race during VM recovery flow
......................................................................

Patch Set 1: (3 inline comments)

....................................................
Commit Message
Line 11: * Add identifier ID and __eq__ to Drive and NIC devices.
Sure, I'll do it

....................................................
File vdsm/libvirtvm.py
Line 926:     def __eq__(self, other):
Hmmm, mybe you right, but I can't imagine that somebody will compare two different classes and anyway it will return false in this case.

Line 927:         return self.ID == other.ID
This comparison I need for my purposes in hotplug

--
To view, visit http://gerrit.ovirt.org/1174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Add identifier ID and __eq__ to Drive and NIC devices.

[Igor Lvovsky]

Igor Lvovsky has abandoned this change.

Change subject: Add identifier ID and __eq__ to Drive and NIC devices.
......................................................................

Patch Set 2: Abandoned

Not need it anymore, partially covered in Federico's livesnapshot patch

--
To view, visit http://gerrit.ovirt.org/1174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi