9:21 a.m.
Vinzenz Feenstra has uploaded a new change for review.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
vdsm: Vm remove unused method _incomingMigrationPending
Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M vdsm/vm/vm.py
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/10870/1
diff --git a/vdsm/vm/vm.py b/vdsm/vm/vm.py
index 5fca0f0..b2de4d2 100644
--- a/vdsm/vm/vm.py
+++ b/vdsm/vm/vm.py
@@ -501,9 +501,6 @@
self.log.error("The vm start process failed", exc_info=True)
self.setDownStatus(ERROR, str(e))
- def _incomingMigrationPending(self):
- return 'migrationDest' in self.conf or 'restoreState' in
self.conf
-
def stopDisksStatsCollection(self):
self._volumesPrepared = False
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
10:24 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1004/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1039/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/150/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:21 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1039/ (3/3)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:18 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/150/ (2/3)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:16 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1004/ (1/3)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:33 a.m.
Vinzenz Feenstra has abandoned this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Abandoned
Out of date
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:21 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/638/ (2/2)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:21 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/673/ (1/2)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:34 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/978/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1013/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/124/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:28 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/124/ (3/3)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1013/ (2/3)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:24 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/978/ (1/3)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:44 a.m.
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
I love when the code size is reduced (especially if it not at a complexity cost).
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:46 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/878/ (2/2)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:48 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/843/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/878/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:45 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/843/ (1/2)
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Vm remove unused method _incomingMigrationPending
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/638/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/673/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/10870
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3852
days inactive
4122
days old
vdsm-patches@lists.fedorahosted.org
16 comments
3 participants
participants (3)
-
asegurap＠redhat.com -
Jenkins CI RO -
Vinzenz Feenstra