12:59 a.m.
Eduardo has uploaded a new change for review.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Provisional fix: the domain is produced in the monitor thread.
This should reduce the number of vgs in connectStoragePool thread.
Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
---
M vdsm/storage/domainMonitor.py
M vdsm/storage/sp.py
2 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/7163/1
diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py
index afda7b1..8bae2f6 100644
--- a/vdsm/storage/domainMonitor.py
+++ b/vdsm/storage/domainMonitor.py
@@ -75,18 +75,18 @@
def monitoredDomains(self):
return self._domains.keys()
- def startMonitoring(self, domain, hostId):
- if domain.sdUUID in self._domains:
+ def startMonitoring(self, sdUUID, hostId):
+ if sdUUID in self._domains:
return
status = DomainMonitorStatus()
stopEvent = Event()
thread = Thread(target=self._monitorDomain,
- args=(domain, hostId, stopEvent, status))
+ args=(sdUUID, hostId, stopEvent, status))
thread.setDaemon(True)
thread.start()
- self._domains[domain.sdUUID] = (stopEvent, thread, status)
+ self._domains[sdUUID] = (stopEvent, thread, status)
def stopMonitoring(self, sdUUID):
if sdUUID not in self._domains:
@@ -110,7 +110,8 @@
for sdUUID in self._domains.keys():
self.stopMonitoring(sdUUID)
- def _monitorDomain(self, domain, hostId, stopEvent, status):
+ def _monitorDomain(self, sdUUID, hostId, stopEvent, status):
+ domain = sdCache.produce(sdUUID)
nextStatus = DomainMonitorStatus()
isIsoDomain = domain.isISO()
lastRefresh = time()
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index ee45151..7ca2cd6 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1554,7 +1554,7 @@
if sdUUID not in monitoredDomains:
try:
self.domainMonitor \
- .startMonitoring(sdCache.produce(sdUUID), self.id)
+ .startMonitoring(sdUUID, self.id)
self.log.debug("Storage Pool `%s` started monitoring "
"domain `%s`", self.spUUID, sdUUID)
except se.StorageException:
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
11:06 a.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
Igor Lvovsky has submitted this change and it was merged.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Produce the domain in the domain monitor thread
This should reduce the number of vgs in connectStoragePool thread.
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=846376
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
---
M vdsm/storage/domainMonitor.py
M vdsm/storage/sdc.py
M vdsm/storage/sp.py
3 files changed, 39 insertions(+), 24 deletions(-)
Approvals:
Igor Lvovsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:06 a.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
Igor Lvovsky has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 6: Verified; Looks good to me, approved
Restore Ayal's and Rami's ACKs
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:11 a.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/830/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8:17 a.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
Rami Vaknin has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 5: Verified
The number of vgs calls haven't changed, however the connectStoragePool takes only 13
seconds now (20 hosts, 50 iscsi storage domains.
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Rami Vaknin <rvaknin.redhat.com(a)gmail.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:50 a.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
Ayal Baron has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:28 a.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/753/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:35 p.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
Ayal Baron has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:24 p.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/639/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:35 a.m.
New subject: Change in vdsm[master]: Produce the domain in the domain monitor thread
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/617/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:13 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 121: self.refreshTime = \
Line 122: config.getint("irs",
"repo_stats_cache_refresh_timeout")
Line 123:
Line 124: def start(self):
Line 125: self.domain = sdCache.produce(self.sdUUID)
I think that the problem persists. What if this throws an exception? We'll have the
domain monitor in self._domains but the thread failed to start (who is going to cleanup
self._domains[sdUUID]?).
Line 126: self.isIsoDomain = self.domain.isISO()
Line 127: self.thread.start()
Line 128:
Line 129: def stop(self, wait=True):
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11:13 a.m.
Ayal Baron has posted comments on this change.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:28 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/457/ : ABORTED
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:37 a.m.
Shu Ming has posted comments on this change.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
I am quite confused with the sentence in the commit message. "This should reduce the
number of vgs in connectStoragePool thread". I think this delay the domain creation
in sd.Cache from StoragePool.updateMonitoringThreads() to DomainMonitor._monitorDomain().
How does it can reduce the number of vgs in host?
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:48 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Downvoting for an open question and because it needs rebasing.
....................................................
File vdsm/storage/domainMonitor.py
Line 110: for sdUUID in self._domains.keys():
Line 111: self.stopMonitoring(sdUUID)
Line 112:
Line 113: def _monitorDomain(self, sdUUID, hostId, stopEvent, status):
Line 114: domain = sdCache.produce(sdUUID)
What if the produce throws an exception? The thread is going to die and nobody would
notice?
Line 115: nextStatus = DomainMonitorStatus()
Line 116: isIsoDomain = domain.isISO()
Line 117: lastRefresh = time()
Line 118: refreshTime = config.getint("irs",
"repo_stats_cache_refresh_timeout")
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12:59 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Provisional fix: the domain is produced in the monitor thread.
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/442/ : ABORTED
--
To view, visit http://gerrit.ovirt.org/7163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2d332b7bc930e681ba23141978ea4f523338d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4110
days inactive
4130
days old
vdsm-patches@lists.fedorahosted.org
15 comments
7 participants
participants (7)
-
abaron＠redhat.com -
ewarszaw＠redhat.com -
Federico Simoncelli -
Igor Lvovsky -
Jenkins CI RO -
rvaknin.redhat.com＠gmail.com -
shuming＠linux.vnet.ibm.com