Change in vdsm[master]: vm: event: send status event on IO Error

Michal Skrivanek has posted comments on this change.

Change subject: vm: event: send status event on IO Error
......................................................................


Patch Set 21:

(1 comment)

https://gerrit.ovirt.org/#/c/43312/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3622:         else:
Line 3623:             io_error_info['name'] = drive.name
Line 3624:             io_error_info['path'] = drive.path
Line 3625: 
Line 3626:         self.send_status_event(pauseCode=reason, ioerror=io_error_info)
>  we should document the data sent back in events - at least the
> minimal key  
I asked Piotr&Oved the same question...we need to have some
documentation guidelines before it's a complete mess.
I don't think we have anything yet:(
Line 3627: 
Line 3628:     @property
Line 3629:     def hasSpice(self):
Line 3630:         return (self.conf.get('display') == 'qxl' or


-- 
To view, visit https://gerrit.ovirt.org/43312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa4be90f1267e82b8af2abb36c06cfd9a70fb558
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes