Change in vdsm[master]: Add the device type in the snapshot dictionary

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Add the device type in the snapshot dictionary
......................................................................

Add the device type in the snapshot dictionary

Since commit 3c1dad8 (Fix vdsm disks ops for the new API) it is required
to pass the device type to prepareVolumePath.

Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/2437/1
--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Add the device type in the snapshot dictionary
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Igor Lvovsky

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Add the device type in the snapshot dictionary
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Let me check if we need additional fixes.

--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Add the device type in the snapshot dictionary
......................................................................

Patch Set 1: Verified; No score

--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Eduardo has posted comments on this change.

Change subject: Add the device type in the snapshot dictionary
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1560:                 baseDrv = {"device": "disk",
Please see my comment in change #2431.

--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Ayal Baron has posted comments on this change.

Change subject: Add the device type in the snapshot dictionary
......................................................................

Patch Set 1: Looks good to me, approved

This should be pushed in to immediately fix functionality.
Any refactoring should be done afterwards.

--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has submitted this change and it was merged.

Change subject: Add the device type in the snapshot dictionary
......................................................................

Add the device type in the snapshot dictionary

Since commit 3c1dad8 (Fix vdsm disks ops for the new API) it is required
to pass the device type to prepareVolumePath.

Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Federico Simoncelli: Verified
  Igor Lvovsky: Looks good to me, approved

Objections:
  Eduardo: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky