Adam Litke has uploaded a new change for review.
Change subject: blockVolume: Add classmethod helper to clear a metadata slot ......................................................................
blockVolume: Add classmethod helper to clear a metadata slot
Change-Id: I338f3fe5f232b1e6e7e8a2474efabcf56333e1cc Signed-off-by: Adam Litke alitke@redhat.com --- M vdsm/storage/blockVolume.py 1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/44833/1
diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index 79061e5..c6c3938 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -296,16 +296,17 @@ # tags self.setMetaParam(volume.IMAGE, imgUUID)
- def removeMetadata(self, metaId): - """ - Just wipe meta. - """ + @classmethod + def clearMetadataSlot(cls, metaId): try: - self._putMetadata(metaId, {"NONE": "#" * (sd.METASIZE - 10)}) + cls._putMetadata(metaId, {"NONE": "#" * (sd.METASIZE - 10)}) except Exception as e: - self.log.error(e, exc_info=True) + cls.log.exception(e) raise se.VolumeMetadataWriteError("%s: %s" % (metaId, e))
+ def removeMetadata(self, metaId): + self.clearMetadataSlot(metaId) + @classmethod def newVolumeLease(cls, metaId, sdUUID, volUUID): cls.log.debug("Initializing volume lease volUUID=%s sdUUID=%s, "
automation@ovirt.org has posted comments on this change.
Change subject: blockVolume: Add classmethod helper to clear a metadata slot ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: blockVolume: Add classmethod helper to clear a metadata slot ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: blockVolume: Add classmethod helper to clear a metadata slot ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add classmethod helper to clear a metadata slot ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
Jenkins CI RO has abandoned this change.
Change subject: blockVolume: Add classmethod helper to clear a metadata slot ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
vdsm-patches@lists.fedorahosted.org