Change in vdsm[master]: vdsm.spec: update ptyhon-pthreading

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm.spec: update ptyhon-pthreading
......................................................................

vdsm.spec: update ptyhon-pthreading

F19 should require python-pthreading >= 1.0.2

Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/15395/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 5af9fde..6a8537e 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -94,7 +94,6 @@
 Requires: python-ethtool >= 0.6-3
 Requires: rpm-python
 Requires: nfs-utils
-Requires: python-pthreading
 Requires: m2crypto
 Requires: %{name}-xmlrpc = %{version}-%{release}
 
@@ -140,8 +139,10 @@
 %endif
 %else
 %if 0%{?fedora} >= 19
+Requires: python-pthreading >= 1.0.2
 Requires: fence-agents-all
 %else
+Requires: python-pthreading
 Requires: fence-agents
 %endif
 # Subprocess and thread bug was found on python 2.7.2


--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 4: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm.spec: update python-pthreading
......................................................................


vdsm.spec: update python-pthreading

F19 and EL7 should require python-pthreading >= 1.0.2

Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2664/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1852/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2737/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2663/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1851/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2736/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 3: Verified

Dan, AFAIK there is no more automatically rebase with upstream, we should be OK for add
the change for EL7 at this point.  Thanks !

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 2:

I suppose el7 would have the same f19 issue, but it's less acute since it's not
yet out in the open. So I care much less about the explicit version req.

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

I believe you've dropped the requirement for el6/7.

....................................................
File vdsm.spec.in
Line 92: Requires: ntp
Line 93: Requires: iproute
Line 94: Requires: python-ethtool >= 0.6-3
Line 95: Requires: rpm-python
Line 96: Requires: nfs-utils
I think you could keep the requirement here, so it affects el6/7 builds as well, and avoid
adding it for f<=18.
Line 97: Requires: m2crypto
Line 98: Requires: %{name}-xmlrpc = %{version}-%{release}
Line 99: 
Line 100: %ifarch x86_64


--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 2:

gerrit failed but it's not related to the patch.
hudson.plugins.git.GitException: Command "/usr/bin/git fetch -t origin
refs/changes/95/15395/2" returned status code 128:
stdout: 
stderr: fatal: read error: Connection reset by peer

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 2: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2597/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1780/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2672/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: update ptyhon-pthreading
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-06-05 11:25:19 -0400
Line 4: Commit:     Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Line 5: CommitDate: 2013-06-05 11:25:19 -0400
Line 6: 
Line 7: vdsm.spec: update ptyhon-pthreading
agreed. thanks
Line 8: 
Line 9: F19 should require python-pthreading >= 1.0.2
Line 10: 
Line 11: Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c


--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm.spec: update ptyhon-pthreading
......................................................................


Patch Set 1: Fails

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2588/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1770/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2664/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Itamar Heim has posted comments on this change.

Change subject: vdsm.spec: update ptyhon-pthreading
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-06-05 11:25:19 -0400
Line 4: Commit:     Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Line 5: CommitDate: 2013-06-05 11:25:19 -0400
Line 6: 
Line 7: vdsm.spec: update ptyhon-pthreading
s/ptyhon/python/
Line 8: 
Line 9: F19 should require python-pthreading >= 1.0.2
Line 10: 
Line 11: Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c


--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com&gt;

Change in vdsm[master]: vdsm.spec: update python-pthreading

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: update python-pthreading
......................................................................


Patch Set 2:

before I send a new version , let me ask: should we add for el7 >= 1.0.2 isn't
true? 

Thanks!

--
To view, visit http://gerrit.ovirt.org/15395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50a5b7a794b9df135478f3adace7501893d992c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;