Change in vdsm[master]: Escape underscore as well

Saggi Mizrahi has uploaded a new change for review.

Change subject: Escape underscore as well
......................................................................

Escape underscore as well

This prevent collision between 'hello/world' and 'hello_world'

Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
---
M vdsm/storage/storageProviderConnectionMonitor.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/1245/1
--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 171:         return os.path.join(self.localPathBase, self._remotePath.replace("/", "_").replace("_", "__"))
this change add a long line and does not fix the collision: both would end up hello__world. you should probably use re for proper escaping.

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 171:         return os.path.join(self.localPathBase, self._remotePath.replace("/", "_").replace("_", "__"))
I cannot say that I like its two-pass implementation, fileUtils.transformPath does that already.

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg

Saggi Mizrahi has posted comments on this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/storageProviderConnectionMonitor.py
Line 171:         return os.path.join(self.localPathBase, self._remotePath.replace("/", "_").replace("_", "__"))
OK you caught me, I noticed that my implementation varied from transformPath and I just wanted to align the two. I hate transformPath and I don't think it should be used at all as everyone who is using it at the moment is actually doing stuff wrong.

When I get the opportunity to remove transformPath and not have all classes depend on an arbitrary path transformation localPath will just be a random folder name independent from the actual path as this is just stupid.

I just don't want to use transform path. I hate it.

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 2: I would prefer that you didn't submit this

still unfixed.

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 3: I would prefer that you didn't submit this

do you hope that I forget?

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has posted comments on this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 3:

Look at my comment on patchset #1. I really don't want to have to do more code moving right now. Let it be. Please

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 3:

I'm not into code moving - but you should at least replace _ first, then replace /.

Or skip this patch.

At it current state it changes nothing.

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi

Saggi Mizrahi has abandoned this change.

Change subject: Escape underscore as well
......................................................................

Patch Set 3: Abandoned

Took a different direction

--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Saggi Mizrahi