Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Add the vdsm-tool command ......................................................................
[WIP] Add the vdsm-tool command
Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 --- M Makefile.am M configure.ac A vdsm-tool/Makefile.am A vdsm-tool/__init__.py A vdsm-tool/vdsm-tool M vdsm.spec.in 6 files changed, 115 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/295/1 -- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Add the vdsm-tool command ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Add the vdsm-tool command ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Itamar Heim has posted comments on this change.
Change subject: [WIP] Add the vdsm-tool command ......................................................................
Patch Set 2: (1 inline comment)
.................................................... Commit Message Line 7: [WIP] Add the vdsm-tool command maybe explain what is the vdsm-tool command about?
-- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add the vdsm-tool command ......................................................................
Patch Set 4: Verified; Looks good to me, approved
hey! it was impolite to ignore Itamar's comment
-- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add the vdsm-tool command ......................................................................
Add the vdsm-tool command
Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 --- M Makefile.am M configure.ac A vdsm-tool/Makefile.am A vdsm-tool/__init__.py A vdsm-tool/vdsm-tool M vdsm.spec.in 6 files changed, 238 insertions(+), 50 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
vdsm-patches@lists.fedorahosted.org