Change in vdsm[master]: The vdsm/vdsmd.init.in script is a bit complex, so move some...

Wenyi Gao has uploaded a new change for review.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

The vdsm/vdsmd.init.in script is a bit complex, so move some
functions to a new script file "vdsmd-init-utils". The new
file will be installed in "@VDSMDIR@/vdsm".

Make blkid.py pep8 clean

Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Signed-off-by: Wenyi Gao 
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/vdsmd-init-utils
M vdsm/vdsmd.init.in
4 files changed, 465 insertions(+), 450 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/3910/1
--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao

Wenyi Gao has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

The script is too complex and that has to be fixed. However, I do not think that hiding the complexity in vdsmd-init-utils helps anybody.

I would love to see the some of the logic of the script converted into vdsm-tool, were it can be used more comfortably.

....................................................
Commit Message
Line 11: Make blkid.py pep8 clean
probably an old remnant?

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

[Ryan Harper]

Ryan Harper has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1:

Dan,

Looking at vdsm-tool in the tree, it doesn't seem to have much there.  is there an email thread or a changeset with some examples to look at how you want to see the script conversion happen?

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1:

Federico had something written about vdsm-tool, but I'm not sure he has posted it in the recent months.

In my imagination, I see in vdsm-tool a function to configure libvirt, another one to configure multipath, a third that verifies that all required services are up, one to configure the management network for vdsm, etc: all the ugly stuff that vdsm does, in order to prepare the host to be a node in an ovirt setup.

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

Wenyi Gao has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1: No score

I will post a mail to confirm it with Federico.

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Thanks Wenyi for trying to improve the init file. Could you move these utilities to vdsm-tool? For an example of how extending it you can look at:

http://gerrit.ovirt.org/388

http://gerrit.ovirt.org/389

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

Wenyi Gao has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 11: Make blkid.py pep8 clean
Yes, it should be moved out.

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

Wenyi Gao has posted comments on this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1:

Yes, I will move these utilities to vdsm-tool.

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao

Wenyi Gao has abandoned this change.

Change subject: The vdsm/vdsmd.init.in script is a bit complex, so move some functions to a new script file "vdsmd-init-utils". The new file will be installed in "@VDSMDIR@/vdsm".
......................................................................

Patch Set 1: Abandoned

Will submit a new patch

--
To view, visit http://gerrit.ovirt.org/3910
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0077b80ff9f62aa7722994ee19de929804778a49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Ryan Harper 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: Wenyi Gao