10:03 a.m.
Hello Timothy Asir, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/3469
to review the following change.
Change subject: Added getMdUuidMap function in supervdsm.
......................................................................
Added getMdUuidMap function in supervdsm.
getMdUuidMap function returns all md/uuid map. Sample return value
is,
{'/dev/md0': 'e35641fc:621a9fa8:123456e4:a1bc6b5f',
'/dev/md1': '95451662:3945780b:123456a7:f3ad55c5'}
Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/md_utils.py
M vdsm/supervdsmServer.py
4 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/3469/1
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
1:22 a.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Added getMdDeviceUuidMap function in supervdsm.
getMdDeviceUuidMap function returns all md/uuid map. Sample return value
is,
{'/dev/md0': 'e35641fc:621a9fa8:123456e4:a1bc6b5f',
'/dev/md1': '95451662:3945780b:123456a7:f3ad55c5'}
Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M Makefile.am
M tests/Makefile.am
A tests/md_utils_tests.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/md_utils.py
M vdsm/supervdsmServer.py
7 files changed, 91 insertions(+), 0 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
1:22 a.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:58 p.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
please rebase
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:56 p.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
1:26 a.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Timothy Asir has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
5:38 p.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
7:14 a.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Bala.FA has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File tests/md_utils_tests.py
Line 25: class mdUtilsTests(TestCaseBase):
Done
Line 35: self.assertTrue(uuid ==
'12345695:0b784539:a73e011c:c555adf3')
Done
....................................................
File vdsm/md_utils.py
Line 22:
Done
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:14 p.m.
New subject: Change in vdsm[master]: Added getMdDeviceUuidMap function in supervdsm.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getMdDeviceUuidMap function in supervdsm.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File tests/md_utils_tests.py
Line 25: class mdUtilsTests(TestCaseBase):
ClassNamesShouldBeLikeThis
Line 35: self.assertTrue(uuid ==
'12345695:0b784539:a73e011c:c555adf3')
assertEquals, maybe?
....................................................
File vdsm/md_utils.py
Line 22:
thanks, but please add to pep8 whitelist, so that no one breaks the code style.
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
3:32 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: Added getMdUuidMap function in supervdsm.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
beside the interface issue, I would like to ask for a unit test, and adding the new file
to pep8's whitelist.
....................................................
File vdsm/md_utils.py
Line 30: def getMdUuidMap():
I would very much appreciate a better name/doc/higher-level-interface. Which are the keys
and the values of this map?
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
6:18 a.m.
Bala.FA has posted comments on this change.
Change subject: Added getMdUuidMap function in supervdsm.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/md_utils.py
Line 30: def getMdUuidMap():
Done
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
4440
days inactive
4453
days old
vdsm-patches@lists.fedorahosted.org
10 comments
3 participants
participants (3)
-
barumuga＠redhat.com -
Dan Kenigsberg -
tjeyasin＠redhat.com