The attached patch makes some changes to the XML output of virt-inspector. Firstly, it changes the output code to use XML:Writer. This changes:
* Single quotes for attributes become double quotes * All data is properly escaped * Indentation
In practise, these should be invisible. It also changes the output semantically in 2 ways:
* /operatingsystems/operatingsystem/os is renamed to /operatingsystems/operatingsystem/name
* /operatingsystems/kernels/version becomes an attribute of /operatingsystems/kernel for consistency with initrds
Are these changes likely to cause problems?
Matt
On Fri, Jun 26, 2009 at 11:44:37AM +0100, Matthew Booth wrote: [...]
The patch makes a lot of sense ...
@@ -30,6 +30,7 @@ eval "use Sys::Virt;"; eval "use XML::XPath;"; eval "use XML::XPath::XMLParser;"; eval "use YAML::Any;"; +eval "use XML::Writer;";
Is it worth making this module required?
Rich.