[PATCH] arrange to build some generated sources

[Jim Meyering]

Hi Rich,

I've just pulled the latest, and then ran this:

git clean -x -d -f && ./autogen.sh

First problem was this:

*** No rule to make target `guestfs-structs.h'

I worked around it with the patch below,
but then got this:

libtool: link: CURRENT `' must be a nonnegative integer
    libtool: link: `:0:' is not valid version information
    make[3]: *** [libguestfs.la] Error 1
> From 82ae736bb0ddcec56a4a6e756b3064c6548724fb Mon Sep 17 00:00:00 2001

From: Jim Meyering 
Date: Thu, 2 Jul 2009 13:30:07 +0200
Subject: [PATCH] arrange to build some generated sources

* src/Makefile.am (BUILT_SOURCES): Define.
($(BUILT_SOURCES)): Depend on stamp-generator.
---
 src/Makefile.am |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index eb8723a..1c0fa0a 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -81,6 +81,15 @@ lib_LTLIBRARIES = libguestfs.la
 # Note that this scheme means the real library version will always be
 # 'libguestfs.so.0.$(MAX_PROC_NR).0'.

+BUILT_SOURCES = \
+  guestfs_protocol.x \
+  guestfs-structs.h \
+  guestfs-actions.h \
+  guestfs-actions.c \
+  guestfs-bindtests.c
+
+$(BUILT_SOURCES): stamp-generator
+
 libguestfs_la_LDFLAGS = -version-info $(MAX_PROC_NR):0:$(MAX_PROC_NR)
 libguestfs_la_SOURCES = \
    guestfs.c \
--
1.6.3.3.507.gc6b5a

[Richard W.M. Jones]

On Thu, Jul 02, 2009 at 01:32:01PM +0200, Jim Meyering wrote:
> Hi Rich,
>
> I've just pulled the latest, and then ran this:
>
> git clean -x -d -f && ./autogen.sh
>
> First problem was this:
>
> *** No rule to make target `guestfs-structs.h'
>
> I worked around it with the patch below,

That patch is fine, +1.
> but then got this:
> libtool: link: CURRENT `' must be a nonnegative integer
> libtool: link: `:0:' is not valid version information
> make[3]: *** [libguestfs.la] Error 1

This should be fixed by this commit:

http://git.et.redhat.com/?p=libguestfs.git;a=commitdiff;h=cf61715fa7f8dcf644...

Rich.