Former code behaved badly when `pgrep qemu` was empty.
Thanks to lihuang of BZ#609016 --- ksmtuned | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ksmtuned b/ksmtuned index 205ff84..d5d1494 100644 --- a/ksmtuned +++ b/ksmtuned @@ -71,8 +71,8 @@ KSMCTL () { committed_memory () { # calculate how much memory is committed to running qemu processes local progname - progname=${1:-qemu} - ps -o vsz `pgrep $progname` | awk '{ sum += $1 }; END { print sum }' + progname=${1:-qemu-kvm} + ps -C "$progname" -o rsz | awk '{ sum += $1 }; END { print sum }' }
free_memory () {
On Thu, 2010-08-26 at 11:23 +0300, Dan Kenigsberg wrote:
Former code behaved badly when `pgrep qemu` was empty.
Thanks to lihuang of BZ#609016
ksmtuned | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ksmtuned b/ksmtuned index 205ff84..d5d1494 100644 --- a/ksmtuned +++ b/ksmtuned @@ -71,8 +71,8 @@ KSMCTL () { committed_memory () { # calculate how much memory is committed to running qemu processes local progname
- progname=${1:-qemu}
- ps -o vsz `pgrep $progname` | awk '{ sum += $1 }; END { print sum }'
- progname=${1:-qemu-kvm}
- ps -C "$progname" -o rsz | awk '{ sum += $1 }; END { print sum }'
}
free_memory () {
Applied upstream. Will make the next Fedora packages.
Thanks
On Thu, Aug 26, 2010 at 11:43:01AM -0500, Justin M. Forbes wrote:
On Thu, 2010-08-26 at 11:23 +0300, Dan Kenigsberg wrote:
Former code behaved badly when `pgrep qemu` was empty.
Thanks to lihuang of BZ#609016
ksmtuned | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ksmtuned b/ksmtuned index 205ff84..d5d1494 100644 --- a/ksmtuned +++ b/ksmtuned @@ -71,8 +71,8 @@ KSMCTL () { committed_memory () { # calculate how much memory is committed to running qemu processes local progname
- progname=${1:-qemu}
- ps -o vsz `pgrep $progname` | awk '{ sum += $1 }; END { print sum }'
- progname=${1:-qemu-kvm}
- ps -C "$progname" -o rsz | awk '{ sum += $1 }; END { print sum }'
}
free_memory () {
Applied upstream. Will make the next Fedora packages.
I hate to nag, but why isn't it here http://pkgs.fedoraproject.org/gitweb/?p=qemu.git;a=summary yet?
On Fri, 2010-09-17 at 15:17 +0200, Dan Kenigsberg wrote:
On Thu, Aug 26, 2010 at 11:43:01AM -0500, Justin M. Forbes wrote:
On Thu, 2010-08-26 at 11:23 +0300, Dan Kenigsberg wrote:
Former code behaved badly when `pgrep qemu` was empty.
Thanks to lihuang of BZ#609016
ksmtuned | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ksmtuned b/ksmtuned index 205ff84..d5d1494 100644 --- a/ksmtuned +++ b/ksmtuned @@ -71,8 +71,8 @@ KSMCTL () { committed_memory () { # calculate how much memory is committed to running qemu processes local progname
- progname=${1:-qemu}
- ps -o vsz `pgrep $progname` | awk '{ sum += $1 }; END { print sum }'
- progname=${1:-qemu-kvm}
- ps -C "$progname" -o rsz | awk '{ sum += $1 }; END { print sum }'
}
free_memory () {
Applied upstream. Will make the next Fedora packages.
I hate to nag, but why isn't it here http://pkgs.fedoraproject.org/gitweb/?p=qemu.git;a=summary yet?
It got overwritten when I did the base update. I realized it as soon as I did the commit, but knew there would be another update very soon (as in the next day or two), so didn't see the need to make another quick build for just that change.
Justin