Wiki Patch

[Ricky Zhou]

Hi!

In the kindofblue theme, the sidebar is absolutely positioned, which
makes it overlap/cover the footer on short pages (e.g.
http://fedoraproject.org/wiki/Websites/Join?action=info).

I've made a quick patch to switch to a float-based layout and avoid this
problem.  The patch also replaces "sidebar-header" (purely
presentational markup) with a background-image on #header (this required
me to alter wiki-sidebar-header.png slightly).

I've put the relevant files up here:
http://fedoraproject.org/wiki/RickyZhou/kindofblue

Side note: I just joined this group yesterday, so please let me know if
there are any tasks that I can look at/get involved in.

Thanks,
Ricky

[Mike McGrath]

Ricky Zhou wrote:
>  Hi!
>
>  In the kindofblue theme, the sidebar is absolutely positioned, which
>  makes it overlap/cover the footer on short pages (e.g.
>  http://fedoraproject.org/wiki/Websites/Join?action=info).
>
>  I've made a quick patch to switch to a float-based layout and avoid this
>  problem.  The patch also replaces "sidebar-header" (purely
>  presentational markup) with a background-image on #header (this required
>  me to alter wiki-sidebar-header.png slightly).
>
>  I've put the relevant files up here:
>  http://fedoraproject.org/wiki/RickyZhou/kindofblue
>
>  Side note: I just joined this group yesterday, so please let me know if
>  there are any tasks that I can look at/get involved in.
>     
As long as I get the ok from one of the 'website regulars' I'll commit 
this and import it.  Thomas, karsten, patrick, glezos?  anyone?

    -Mike

[Rahul Sundaram]

Mike McGrath wrote:
>  Ricky Zhou wrote:
> > Hi!
> >
> > In the kindofblue theme, the sidebar is absolutely positioned, which
> > makes it overlap/cover the footer on short pages (e.g.
> > http://fedoraproject.org/wiki/Websites/Join?action=info).
> >
> > I've made a quick patch to switch to a float-based layout and avoid this
> > problem.  The patch also replaces "sidebar-header" (purely
> > presentational markup) with a background-image on #header (this required
> > me to alter wiki-sidebar-header.png slightly).
> >
> > I've put the relevant files up here:
> > http://fedoraproject.org/wiki/RickyZhou/kindofblue
> >
> > Side note: I just joined this group yesterday, so please let me know if
> > there are any tasks that I can look at/get involved in.
> >   
>  
>  As long as I get the ok from one of the 'website regulars' I'll commit 
>  this and import it.  Thomas, karsten, patrick, glezos?  anyone? 
This is something I already requested in the wiki upgrade before. There 
is already a patch from Patrick Barnes floating around. We need to make 
sure we get this patch committed upstream though. Other than that I am 
all for it.

Rahul

[Thomas Chung]

On 4/25/07, Mike McGrath <mmcgrath(a)redhat.com&gt; wrote:
>  Ricky Zhou wrote:
>  > Hi!
>  >
>  > In the kindofblue theme, the sidebar is absolutely positioned, which
>  > makes it overlap/cover the footer on short pages (e.g.
>  > http://fedoraproject.org/wiki/Websites/Join?action=info).
>  >
>  > I've made a quick patch to switch to a float-based layout and avoid this
>  > problem.  The patch also replaces "sidebar-header" (purely
>  > presentational markup) with a background-image on #header (this required
>  > me to alter wiki-sidebar-header.png slightly).
>  >
>  > I've put the relevant files up here:
>  > http://fedoraproject.org/wiki/RickyZhou/kindofblue
>  >
>  > Side note: I just joined this group yesterday, so please let me know if
>  > there are any tasks that I can look at/get involved in.
>  >
>
>  As long as I get the ok from one of the 'website regulars' I'll commit
>  this and import it.  Thomas, karsten, patrick, glezos?  anyone?
>
>      -Mike
>  
I'm no expert on this area but It looks good to me. :)
Dimitris, please review the the patch be we commit.
Regards,
-- 
Thomas Chung
http://fedoraproject.org/wiki/ThomasChung

[Karsten Wade]

On Thu, 2007-04-26 at 05:08 +0530, Rahul Sundaram wrote:

>  This is something I already requested in the wiki upgrade before.
> There 
>  is already a patch from Patrick Barnes floating around. We need to make 
>  sure we get this patch committed upstream though. Other than that I am 
>  all for it. 
A CSS patch upstream?  Oh, it's the kindofblue.py.  Since that is
presentation layer stuff, even if it is Python and not CSS, is that
something that upstream wants?  Is there a way we can carry Python
patches the way we carry CSS patches?

For CSS, it is nice that you can define a style as the main style that
overrides other settings, so it is very different from a traditional
patch.  Yet, changes in the upstream CSS can require changes in our
custom CSS ... and thus isn't far off from the situation with
kindofblue.py.

I think we need to implement the fix and document it, just as we do CSS,
server configurations, etc.  Call it a customization in the form of a
Python patch. :)

- Karsten
-- 
   Karsten Wade, 108 Editor       ^     Fedora Documentation Project 
 Sr. Developer Relations Mgr.     |  fedoraproject.org/wiki/DocsProject
   quaid.108.redhat.com           |          gpg key: AD0E0C41
////////////////////////////////// \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\

[Dimitris Glezos]

O/H Thomas Chung έγραψε:
>  On 4/25/07, Mike McGrath <mmcgrath(a)redhat.com&gt; wrote:
> > Ricky Zhou wrote:
> > >
> > > In the kindofblue theme, the sidebar is absolutely positioned, which
> > > makes it overlap/cover the footer on short pages (e.g.
> > > http://fedoraproject.org/wiki/Websites/Join?action=info).
> > >
> > > I've made a quick patch to switch to a float-based layout and avoid
> > this
> > > problem.  The patch also replaces "sidebar-header" (purely
> > > presentational markup) with a background-image on #header (this
> > required
> > > me to alter wiki-sidebar-header.png slightly).
> > >
> > > I've put the relevant files up here:
> > > http://fedoraproject.org/wiki/RickyZhou/kindofblue
> > >
> > > Side note: I just joined this group yesterday, so please let me know if
> > > there are any tasks that I can look at/get involved in.
> >
> > As long as I get the ok from one of the 'website regulars' I'll commit
> > this and import it.  Thomas, karsten, patrick, glezos?  anyone?
>  
>  I'm no expert on this area but It looks good to me. :)
>  Dimitris, please review the the patch be we commit. 
Patch seems OK to me; thanks for the initiative & patch Ricky. :)

The new `wiki-sidebar-header.png` has slightly different colors than the
original and the `repeat-y` property makes it look ragged. Ricky, could you
please create one which has a consistent blue color across the x-axis and make
it 5px high instead of 1?

After you commit the changes to our CVS (you have write acess AFAICT), I can
then double-check them out locally to make sure everything is OK and ask Mike to
make the final CVS changes live.

-d


-- 
Dimitris Glezos
Jabber ID: glezos(a)jabber.org, GPG: 0xA5A04C3B
http://dimitris.glezos.com/

"He who gives up functionality for ease of use
loses both and deserves neither." (Anonymous)
--

[Ricky Zhou]

Dimitris Glezos wrote:
>  The new `wiki-sidebar-header.png` has slightly different colors than
> the
>  original and the `repeat-y` property makes it look ragged. Ricky, could you
>  please create one which has a consistent blue color across the x-axis and make
>  it 5px high instead of 1? 
Good catch- I was kind of lazy and just copied the image
from a screen
capture.  I've changed the image on my test site and uploaded it to
http://fedoraproject.org/wiki/RickyZhou/kindofblue.  To me, it looks
smoother (horizontally) than http://fedoraproject.org/wiki/, but it
could just be my screen/display, I guess.  Does it look right now?

>  After you commit the changes to our CVS (you have write acess
> AFAICT), I can
>  then double-check them out locally to make sure everything is OK and ask Mike to
>  make the final CVS changes live. 
Hmm..  I'm not sure about CVS access- I
haven't taken any action to get
it (I just came here on Tuesday), and I don't think it's enabled by
default.

Thanks,
Ricky