Hello. I've made a patch to fix this following problems (description copied from https://fedoraproject.org/wiki/Website_redesign/WwwfpoFixes ): * The text is not starting from the right (add direction:rtl, it will fix most RTL problems) * In the download splash, one of the speech bubbles is under the others. * Fedora highlights has displays as multicolumn, but only one filled * he (Hebrew) the OK button (אישור) is under and not beside the languages list (caused because אישור is a bit longer than OK) In addition, this patch also add /n's to the rtl_960.css file, making it much more readable.
http://elad.fedorapeople.org/RTL_And_Hebrew_Fixes.patch
I hope I'll be able to fix more problems soon (the header mess is a bit difficult to fix, but I'll try).
I've managed to fix these problems too: * In the header, the Fedora logo is at the middle * The header is one big mess
http://elad.fedorapeople.org/RTL_Fixes2.patch
Should be applied after my previous patch. More fixes, if needed, are soon to come :-)
2010/10/18 אלעד el.il@doom.co.il:
Hello. I've made a patch to fix this following problems (description copied from https://fedoraproject.org/wiki/Website_redesign/WwwfpoFixes ):
- The text is not starting from the right (add direction:rtl, it will
fix most RTL problems)
- In the download splash, one of the speech bubbles is under the others.
- Fedora highlights has displays as multicolumn, but only one filled
- he (Hebrew) the OK button (אישור) is under and not beside the
languages list (caused because אישור is a bit longer than OK) In addition, this patch also add /n's to the rtl_960.css file, making it much more readable.
http://elad.fedorapeople.org/RTL_And_Hebrew_Fixes.patch
I hope I'll be able to fix more problems soon (the header mess is a bit difficult to fix, but I'll try). --
Elad
I've updated the second patch to fix the four F's position as well. RTL problems that still need to be fixed: * After applying my patches, the language selector OK button moved to the left side of the list, so the globe should be moved to the right side. * The tabs in the feature page need to be in the top right side of the page, not top left.
2010/10/18 אלעד el.il@doom.co.il:
I've managed to fix these problems too: * In the header, the Fedora logo is at the middle * The header is one big mess
http://elad.fedorapeople.org/RTL_Fixes2.patch
Should be applied after my previous patch. More fixes, if needed, are soon to come :-)
2010/10/18 אלעד el.il@doom.co.il:
Hello. I've made a patch to fix this following problems (description copied from https://fedoraproject.org/wiki/Website_redesign/WwwfpoFixes ):
- The text is not starting from the right (add direction:rtl, it will
fix most RTL problems)
- In the download splash, one of the speech bubbles is under the others.
- Fedora highlights has displays as multicolumn, but only one filled
- he (Hebrew) the OK button (אישור) is under and not beside the
languages list (caused because אישור is a bit longer than OK) In addition, this patch also add /n's to the rtl_960.css file, making it much more readable.
http://elad.fedorapeople.org/RTL_And_Hebrew_Fixes.patch
I hope I'll be able to fix more problems soon (the header mess is a bit difficult to fix, but I'll try). --
Elad
--
Elad
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
2010/10/18 אלעד el.il@doom.co.il:
I've updated the second patch to fix the four F's position as well. RTL problems that still need to be fixed: * After applying my patches, the language selector OK button moved to the left side of the list, so the globe should be moved to the right side. * The tabs in the feature page need to be in the top right side of the page, not top left.
2010/10/18 אלעד el.il@doom.co.il:
I've managed to fix these problems too: * In the header, the Fedora logo is at the middle * The header is one big mess
http://elad.fedorapeople.org/RTL_Fixes2.patch
Should be applied after my previous patch. More fixes, if needed, are soon to come :-)
2010/10/18 אלעד el.il@doom.co.il:
Hello. I've made a patch to fix this following problems (description copied from https://fedoraproject.org/wiki/Website_redesign/WwwfpoFixes ):
- The text is not starting from the right (add direction:rtl, it will
fix most RTL problems)
- In the download splash, one of the speech bubbles is under the others.
- Fedora highlights has displays as multicolumn, but only one filled
- he (Hebrew) the OK button (אישור) is under and not beside the
languages list (caused because אישור is a bit longer than OK) In addition, this patch also add /n's to the rtl_960.css file, making it much more readable.
http://elad.fedorapeople.org/RTL_And_Hebrew_Fixes.patch
I hope I'll be able to fix more problems soon (the header mess is a bit difficult to fix, but I'll try). --
Elad
--
Elad
--
Elad
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote:
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
2010/10/20 shaiton shaiton@fedoraproject.org:
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote:
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
-- Kévin Raymond GPG-Key: A5BCB3A2
the Hebrew specific fix is for a problem that doesn't appear in chrome (but does appear in FF): the ok button (אישור) of the language list is under, and not beside the list. it caused because of the word אישור is longer than the word ok.
also, i think you should add !important to this property .webpage-list, .checkmark-list { padding-right:15px; }
40px padding is too much for those lists.
screenshots that shows the problems are attached.
thank you for applying my patches.
2010/10/20 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote:
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
-- Kévin Raymond GPG-Key: A5BCB3A2
the Hebrew specific fix is for a problem that doesn't appear in chrome (but does appear in FF): the ok button (אישור) of the language list is under, and not beside the list. it caused because of the word אישור is longer than the word ok.
ignore that, this commit http://git.fedorahosted.org/git?p=fedora-web.git;a=commit;h=2cf67805f1b1b7dc... caused a strange behavior in RTL, so my fix for isn't needed anymore (i need another fix though).
also, i think you should add !important to this property .webpage-list, .checkmark-list { padding-right:15px; }
40px padding is too much for those lists.
screenshots that shows the problems are attached.
thank you for applying my patches.
--
Elad
On Wed, Oct 20, 2010 at 5:52 PM, Elad el.il@doom.co.il wrote:
2010/10/20 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote:
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
-- Kévin Raymond GPG-Key: A5BCB3A2
the Hebrew specific fix is for a problem that doesn't appear in chrome (but does appear in FF): the ok button (אישור) of the language list is under, and not beside the list. it caused because of the word אישור is longer than the word ok.
ignore that, this commit http://git.fedorahosted.org/git?p=fedora-web.git;a=commit;h=2cf67805f1b1b7dc... caused a strange behavior in RTL, so my fix for isn't needed anymore (i need another fix though).
also, i think you should add !important to this property .webpage-list, .checkmark-list { padding-right:15px; }
40px padding is too much for those lists.
screenshots that shows the problems are attached.
thank you for applying my patches.
--
Elad
--
אלעד
fixed
here is another small fix, please add this to fpo960-rtl.css: #features-content img { float: right; margin-left: 15px; margin-right: 0px; } it will fix the icon positions in the features page.
2010/10/20 shaiton shaiton@fedoraproject.org:
On Wed, Oct 20, 2010 at 5:52 PM, Elad el.il@doom.co.il wrote:
2010/10/20 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote:
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
-- Kévin Raymond GPG-Key: A5BCB3A2
the Hebrew specific fix is for a problem that doesn't appear in chrome (but does appear in FF): the ok button (אישור) of the language list is under, and not beside the list. it caused because of the word אישור is longer than the word ok.
ignore that, this commit http://git.fedorahosted.org/git?p=fedora-web.git;a=commit;h=2cf67805f1b1b7dc... caused a strange behavior in RTL, so my fix for isn't needed anymore (i need another fix though).
also, i think you should add !important to this property .webpage-list, .checkmark-list { padding-right:15px; }
40px padding is too much for those lists.
screenshots that shows the problems are attached.
thank you for applying my patches.
--
Elad
--
אלעד
fixed
-- Kévin Raymond GPG-Key: A5BCB3A2
2010/10/20 shaiton shaiton@fedoraproject.org:
On Wed, Oct 20, 2010 at 5:52 PM, Elad el.il@doom.co.il wrote:
2010/10/20 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote:
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
-- Kévin Raymond GPG-Key: A5BCB3A2
the Hebrew specific fix is for a problem that doesn't appear in chrome (but does appear in FF): the ok button (אישור) of the language list is under, and not beside the list. it caused because of the word אישור is longer than the word ok.
ignore that, this commit http://git.fedorahosted.org/git?p=fedora-web.git;a=commit;h=2cf67805f1b1b7dc... caused a strange behavior in RTL, so my fix for isn't needed anymore (i need another fix though).
also, i think you should add !important to this property .webpage-list, .checkmark-list { padding-right:15px; }
40px padding is too much for those lists.
screenshots that shows the problems are attached.
thank you for applying my patches.
--
Elad
--
אלעד
fixed
-- Kévin Raymond GPG-Key: A5BCB3A2
Sorry about the top posting i made in my previous message.
anyway, i've found another problematic rule in rtl_960.css: .container_16 .prefix_14 { padding-right: 840px; } should be deleted or otherwise overridden, as it causes the "back to top" button to be in a wrong position.
2010/10/21 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Wed, Oct 20, 2010 at 5:52 PM, Elad el.il@doom.co.il wrote:
2010/10/20 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote:
I'm sorry for flooding your mailing list, but i've updated my second patch again, now it also moves the globe of the language list to the right side of the list, fixes the positions of the features page tabs, and fixes a little problem with the links in the left side of the main page.
now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
-- Kévin Raymond GPG-Key: A5BCB3A2
the Hebrew specific fix is for a problem that doesn't appear in chrome (but does appear in FF): the ok button (אישור) of the language list is under, and not beside the list. it caused because of the word אישור is longer than the word ok.
ignore that, this commit http://git.fedorahosted.org/git?p=fedora-web.git;a=commit;h=2cf67805f1b1b7dc... caused a strange behavior in RTL, so my fix for isn't needed anymore (i need another fix though).
also, i think you should add !important to this property .webpage-list, .checkmark-list { padding-right:15px; }
40px padding is too much for those lists.
screenshots that shows the problems are attached.
thank you for applying my patches.
--
Elad
--
אלעד
fixed
-- Kévin Raymond GPG-Key: A5BCB3A2
Sorry about the top posting i made in my previous message.
anyway, i've found another problematic rule in rtl_960.css: .container_16 .prefix_14 { padding-right: 840px; } should be deleted or otherwise overridden, as it causes the "back to top" button to be in a wrong position.
--
אלעד
another problem: while the tutorials and interviews text is untranslatable, the text is still right aligned. in order to fix this, you should surround the content in another div, and define that div as direction: ltr. don't do direction: ltr to the whole page/content, since the titles and the short descriptions are translated.
2010/10/21 Elad el.il@doom.co.il:
2010/10/21 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Wed, Oct 20, 2010 at 5:52 PM, Elad el.il@doom.co.il wrote:
2010/10/20 Elad el.il@doom.co.il:
2010/10/20 shaiton shaiton@fedoraproject.org:
On Mon, Oct 18, 2010 at 12:17 PM, אלעד el.il@doom.co.il wrote: > I'm sorry for flooding your mailing list, but i've updated my second > patch again, > now it also moves the globe of the language list to the right side of > the list, fixes the positions of the features page tabs, and fixes a > little problem with the links in the left side of the main page. > > now there are only one problem, Hebrew specific, that i need to fix. :-)
I've pushed an update. Please, let me know understand what your "Hebrew specific" fix is doing.
+.lang-he #header>.container_16>.grid_3 { +width: 180px; +} Should not be applied for me (it is broking the four foundations columns.)
There is two things that should be corrected. The slideshow has a padding-right who need to be removed (under Firefox4, you won't see it under Chrome). The slideshow numbers are still displayed on the left using Chrome (looks good with Firefox4).
-- Kévin Raymond GPG-Key: A5BCB3A2
the Hebrew specific fix is for a problem that doesn't appear in chrome (but does appear in FF): the ok button (אישור) of the language list is under, and not beside the list. it caused because of the word אישור is longer than the word ok.
ignore that, this commit http://git.fedorahosted.org/git?p=fedora-web.git;a=commit;h=2cf67805f1b1b7dc... caused a strange behavior in RTL, so my fix for isn't needed anymore (i need another fix though).
also, i think you should add !important to this property .webpage-list, .checkmark-list { padding-right:15px; }
40px padding is too much for those lists.
screenshots that shows the problems are attached.
thank you for applying my patches.
--
Elad
--
אלעד
fixed
-- Kévin Raymond GPG-Key: A5BCB3A2
Sorry about the top posting i made in my previous message.
anyway, i've found another problematic rule in rtl_960.css: .container_16 .prefix_14 { padding-right: 840px; } should be deleted or otherwise overridden, as it causes the "back to top" button to be in a wrong position.
--
אלעד
another problem: while the tutorials and interviews text is untranslatable, the text is still right aligned. in order to fix this, you should surround the content in another div, and define that div as direction: ltr. don't do direction: ltr to the whole page/content, since the titles and the short descriptions are translated.
--
אלעד
Since i'm part of the team now, i will make all those fixes myself. thanks.
On Fri, Oct 22, 2010 at 11:34 AM, Elad el.il@doom.co.il wrote: [snip]
--
אלעד
Since i'm part of the team now, i will make all those fixes myself. thanks.
-- -Elad.
Great ;) Welcome Elad.
websites@lists.fedoraproject.org
-
Elad -
Kévin Raymond