[RFC] cleanup warning (redefine MMIO_SIZE)

[Akio Takebe]

Hi, all

This issue is only for fedora-xen-ia64.
fedora-xen-ia64 turn on CONFIG_FB_NEOMAGIC in .config.
(xen-ia64-unstable is default turn off it)
In the case of CONFIG_FB_NEOMAGIC=y, MMIO_SIZE is redefine.
I think MMIO_SIZE in arch-ia64.h is only used 
in arch-ia64.h and xen/arch/ia64/vmx/vmx_init.c.
Am I right?

We should move some defines(e.g. MMIO_xxx) from public header
to not public header because they are used only 
in vmx_init.c, shouldn't we?

fedora-xen-ia64's warning is:
In file included from drivers/video/neofb.c:85:
include/video/neomagic.h:136:1: warning: "MMIO_SIZE" redefined
In file included from include/xen/interface/xen.h:17,
                 from include/asm/hypervisor.h:41,
                 from include/asm/page.h:246,
                 from include/asm/ptrace.h:86,
                 from include/asm/processor.h:20,
                 from include/asm/thread_info.h:11,
                 from include/linux/thread_info.h:21,
                 from include/linux/preempt.h:10,
                 from include/linux/spinlock.h:50,
                 from include/linux/capability.h:45,
                 from include/linux/sched.h:7,
                 from include/linux/module.h:10,
                 from drivers/video/neofb.c:58:
include/xen/interface/arch-ia64.h:71:1: warning: this is the location of 
the previous definition

Best Regards,

Akio Takebe

[Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE)

[Tristan Gingold]

Le Jeudi 01 Juin 2006 13:28, Akio Takebe a écrit :
>  Hi, all
>
>  This issue is only for fedora-xen-ia64.
>  fedora-xen-ia64 turn on CONFIG_FB_NEOMAGIC in .config.
>  (xen-ia64-unstable is default turn off it)
>  In the case of CONFIG_FB_NEOMAGIC=y, MMIO_SIZE is redefine.
>  I think MMIO_SIZE in arch-ia64.h is only used
>  in arch-ia64.h and xen/arch/ia64/vmx/vmx_init.c.
>  Am I right?
>
>  We should move some defines(e.g. MMIO_xxx) from public header
>  to not public header because they are used only
>  in vmx_init.c, shouldn't we? 
Yes.  In my opinion, arch-ia64.h must be as small
as possible and identifiers 
should be in the 'xen' name space.  We are very far from the last point!

Tristan.

[Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE)

[Alex Williamson]

On Thu, 2006-06-01 at 13:47 +0200, Tristan Gingold wrote:
>  Le Jeudi 01 Juin 2006 13:28, Akio Takebe a écrit :
>  > Hi, all
>  >
>  > This issue is only for fedora-xen-ia64.
>  > fedora-xen-ia64 turn on CONFIG_FB_NEOMAGIC in .config.
>  > (xen-ia64-unstable is default turn off it)
>  > In the case of CONFIG_FB_NEOMAGIC=y, MMIO_SIZE is redefine.
>  > I think MMIO_SIZE in arch-ia64.h is only used
>  > in arch-ia64.h and xen/arch/ia64/vmx/vmx_init.c.
>  > Am I right?
>  >
>  > We should move some defines(e.g. MMIO_xxx) from public header
>  > to not public header because they are used only
>  > in vmx_init.c, shouldn't we?
>  Yes.  In my opinion, arch-ia64.h must be as small as possible and identifiers 
>  should be in the 'xen' name space.  We are very far from the last point! 
   I agree as well.  However, I also think the fedora-xen-ia64 tree
should turn off CONFIG_FB_NEOMAGIC.  AFAIK, there's absolutely no way
that you'd ever need to use the NeoMagic frame buffer driver on an ia64
system.  Thanks,

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.

[Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE)

[Akio Takebe]

Hi, Alex, Tristan and Aron

>    I agree as well.  However, I also think the fedora-xen-ia64 tree
> should turn off CONFIG_FB_NEOMAGIC.  AFAIK, there's absolutely no way
> that you'd ever need to use the NeoMagic frame buffer driver on an ia64
> system.  Thanks,
>  
Yes, I agree about turning off NeoMagic.
This is old FB driver.
So I also think NeoMagic isn't needed by ia64.

Aron, could you turn off CONFIG_FB_NEOMAGIC?

BTW, I'll cleanup arch-ia64.h. :-)

Best Regards,

Akio Takebe