Midori 0.4.7 for Fedora 17?

[Heiko Adams]

Hi,
will Feodra 17 or even the Xfce 4.10 siderepo get updated packages for
midori 0.4.7?

[Johannes Lips]

Hello Heiko,

I provide rpms in a repo on repos.fedora people.org which are actually
current git and are already ahead of 0.4.7.

Johannes
On Sep 26, 2012 5:25 PM, "Heiko Adams"  wrote:
> Hi,
> will Feodra 17 or even the Xfce 4.10 siderepo get updated packages for
> midori 0.4.7?
> --
> Regards,
>
> Heiko Adams
> _______________________________________________
> xfce mailing list
> [e-mail]
> https://admin.fedoraproject.org/mailman/listinfo/xfce

[Kevin Fenzi]

On Wed, 26 Sep 2012 18:55:56 +0200
Johannes Lips  wrote:
> Hello Heiko,
>
> I provide rpms in a repo on repos.fedora people.org which are actually
> current git and are already ahead of 0.4.7.
>
> Johannes
> On Sep 26, 2012 5:25 PM, "Heiko Adams"  wrote:
> > Hi,
> > will Feodra 17 or even the Xfce 4.10 siderepo get updated packages
> > for midori 0.4.7?

I can look and see if there are any changes that would make updating
f17 not possible. ;)

If it is, I'd be happy to push a update to it as well.

kevin

[Heiko Adams]

Am 26.09.2012 21:43, schrieb Kevin Fenzi:
> I can look and see if there are any changes that would make
> updating f17 not possible. ;)
>
> If it is, I'd be happy to push a update to it as well.

The Fedora 18 package works fine and without any problems on my Fedora
17 box ;-)

[Kevin Fenzi]

On Wed, 26 Sep 2012 22:18:05 +0200
Heiko Adams  wrote:
> Am 26.09.2012 21:43, schrieb Kevin Fenzi:
> > I can look and see if there are any changes that would make
> > updating f17 not possible. ;)
> >
> > If it is, I'd be happy to push a update to it as well.
>
> The Fedora 18 package works fine and without any problems on my Fedora
> 17 box ;-)

well, it's not just that... for stable releases we are supposed to
avoid changing the 'user experience'. So, menus moving around, or other
things that would cause uses having to re-learn how to use the
application.

kevin

[Martin Sourada]

On Wed, 26 Sep 2012 13:43:16 -0600 
Kevin Fenzi wrote:
> I can look and see if there are any changes that would make updating
> f17 not possible. ;)

It does not build on my F17 machine, because valac is actually
valac-0.16 in current vala rpm. BuildRequire: vala-compat fixes build,
but just like Johannes' git version, private and app mode does not work.

$ midori -a "http://ivysilani.cz/"
**
ERROR:/home/mso/rpmbuild/BUILD/midori-0.4.7/katze/midori-paths.vala:117:midori_paths_get_user_data_dir:
assertion failed: (_tmp0_ != NULL) Aborted (core dumped)

Other than that it would be nice to get it in, the new delayed-load
extension is awesome.

Martin

[Kevin Fenzi]

On Wed, 26 Sep 2012 23:00:35 +0200
Martin Sourada  wrote:
> On Wed, 26 Sep 2012 13:43:16 -0600 
> Kevin Fenzi wrote:
> > I can look and see if there are any changes that would make updating
> > f17 not possible. ;)
>
> It does not build on my F17 machine, because valac is actually
> valac-0.16 in current vala rpm. BuildRequire: vala-compat fixes build,
> but just like Johannes' git version, private and app mode does not
> work.
>
> $ midori -a "http://ivysilani.cz/"
> **
> ERROR:/home/mso/rpmbuild/BUILD/midori-0.4.7/katze/midori-paths.vala:117:midori_paths_get_user_data_dir:
> assertion failed: (_tmp0_ != NULL) Aborted (core dumped)

Yeah, fixed in git: 
http://git.xfce.org/apps/midori/commit/?id=c99d48c65e6271846590c925419487b17...
> Other than that it would be nice to get it in, the new delayed-load
> extension is awesome.

yes, yes it is. ;)

kevin

[Martin Sourada]

On Wed, 26 Sep 2012 15:06:08 -0600 
Kevin Fenzi wrote:
> Yeah, fixed in git: 
> http://git.xfce.org/apps/midori/commit/?id=c99d48c65e6271846590c925419487b17...

I don't think this commit fixes it... Git bisect pointed me to
different place:
http://git.xfce.org/apps/midori/commit/?id=7c26d4ca116f856be92cda371482d5179...

Of course, since parts of the code that this touches changed between
the commit and 0.4.7 it does not apply on the 0.4.7 release at all.
However I was able to figure out a fix based on these changes that
appears to work (I haven't done excessive testing, but the couple of
sites I use with either -a or -p seem to work without problems, as
well as "normal" midori mode). The fix is attached.

Cheers,
Martin

[Kevin Fenzi]

On Tue, 23 Oct 2012 13:54:59 +0200
Martin Sourada  wrote:
> On Wed, 26 Sep 2012 15:06:08 -0600 
> Kevin Fenzi wrote:
> > Yeah, fixed in git: 
> > http://git.xfce.org/apps/midori/commit/?id=c99d48c65e6271846590c925419487b17...
>
> I don't think this commit fixes it... Git bisect pointed me to
> different place:
> http://git.xfce.org/apps/midori/commit/?id=7c26d4ca116f856be92cda371482d5179...
>
> Of course, since parts of the code that this touches changed between
> the commit and 0.4.7 it does not apply on the 0.4.7 release at all.
> However I was able to figure out a fix based on these changes that
> appears to work (I haven't done excessive testing, but the couple of
> sites I use with either -a or -p seem to work without problems, as
> well as "normal" midori mode). The fix is attached.

I suck. I thought I had pushed this out, but it turns out I had it
locally, but hadn't pushed/built it. ;(

Doing so now.

Hopefully 0.4.8 isn't far off too.

kevin