[389-commits] ldap/servers

Richard Allen Megginson rmeggins at fedoraproject.org
Thu Jan 12 15:39:01 UTC 2012


 ldap/servers/plugins/acl/acl_ext.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit e1a7823230d2aaadcea4eecf0794e784c12b33e9
Author: Rich Megginson <rmeggins at redhat.com>
Date:   Wed Jan 11 20:32:45 2012 -0700

    Ticket #256 - debug build assertion in ACL_EvalDestroy()
    
    https://fedorahosted.org/389/ticket/256
    Resolves: Ticket #256
    Bug Description: debug build assertion in ACL_EvalDestroy()
    Reviewed by: nkinder (Thanks!)
    Branch: master
    Fix Description: aclpb->aclpb_acleval does not own its acllist - so use
    ACL_EvalDestroyNoDecrement() instead so the list is not freed.
    Platforms tested: RHEL6 x86_64, Fedora 16
    Flag Day: no
    Doc impact: no

diff --git a/ldap/servers/plugins/acl/acl_ext.c b/ldap/servers/plugins/acl/acl_ext.c
index f045a97..f8699b4 100644
--- a/ldap/servers/plugins/acl/acl_ext.c
+++ b/ldap/servers/plugins/acl/acl_ext.c
@@ -749,8 +749,9 @@ acl__free_aclpb ( Acl_PBlock **aclpb_ptr)
 
     aclpb = *aclpb_ptr;
 
-    if (aclpb->aclpb_acleval)
-        ACL_EvalDestroy(NULL, NULL, aclpb->aclpb_acleval);
+    if (aclpb->aclpb_acleval) {
+        ACL_EvalDestroyNoDecrement(NULL, NULL, aclpb->aclpb_acleval);
+    }
 
     if (aclpb->aclpb_proplist)
         PListDestroy(aclpb->aclpb_proplist);




More information about the 389-commits mailing list