[Fedora-directory-devel] Please review: Bug 199321: incorrect base64 encoding of SHA passwords crashes server

[Richard Megginson]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199321
Bug(s) fixed: 199321
Bug Description:  incorrect base64 encoding of SHA passwords crashes server
Reviewed by: ???
Files: ldapserver/ldap/servers/plugins/pwdstorage/sha_pwd.c
Branch: HEAD
Fix Description: Check the return value of ldif_base64_decode to see if 
it is less than zero first before the other comparisons.  This is the 
error condition, so we can just return an error.  Additionally, the 
other comparisons with the unsigned should be ok since we know that the 
hash_len is a positive number.
Platforms tested: FC5
Flag Day: no
Doc impact: no
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199321#c5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3178 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.fedoraproject.org/pipermail/389-devel/attachments/20061009/618f03ac/attachment.bin