[Fedora-directory-devel] Please review: [Bug 212098] Use autoconf to generate task perl script templates

[Noriko Hosoi]

Thank you for your comments, Andrew and Pete!

Nathan told me that we should check them in since we should not expect 
customers to run autoconf/automake.  But we are skipping to put the 
diffs to the review request.  I think the rule looks similar to the 
samba rule and am going to follow it...

Thanks!
--noriko

Pete Rowley wrote:

> Andrew Bartlett wrote:
>
>> On Wed, 2006-10-25 at 15:43 -0700, Noriko Hosoi wrote:
>>  
>>
>>> Summary: Use autoconf to generate task perl script templates
>>>
>>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212098
>>>
>>> Problem Description:
>>> Notes in Comment#1
>>> 2. The template files are not "installed" now.
>>>
>>> With this change, the perl template files are installed in 
>>> $prefix/etc/brand-ds/script-templates
>>>
>>>  ------- Additional Comments From nhosoi at redhat.com  2006-10-25 
>>> 18:34 EST -------
>>> Created an attachment (id=139419)
>>>  --> 
>>> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=139419&action=view) 
>>>
>>> cvs diff configure.ac Makefile.am
>>>
>>> Files:
>>>   configure.ac
>>>   MAkefile.am
>>>
>>> Changes;
>>> 1) added task perl script templates to "install" at
>>> @sysconfdir@@scripttemplatedir@ to Makefile.am
>>> 2) added scripttemplatedir = /fedora-ds/script-templates to 
>>> configure.ac
>>>
>>> Question: changing these files, Makefile.in and configure are also 
>>> updated.  Am
>>> I supposed to check them in?
>>> M Makefile.am
>>> M Makefile.in
>>> M configure
>>> M configure.ac
>>>     
>>
>>
>> This depends on the project, and I don't know the rules here. 
>> In Samba (just as a note, for comparison), we did commit these generated
>> files our to CVS for many years, but it just created a lot of noise on
>> commit, as different developers had slightly different tools, which
>> would rearrange the files rather often.
>>
>> Our current policy is to generate these files for release tarballs, and
>> for our 'unpacked' tree on samba.org (current SVN checked out).
>>   
>
> OTOH they are required in order to do:
>
> cvs co
> ./configure
> make
>
>
>------------------------------------------------------------------------
>
>--
>Fedora-directory-devel mailing list
>Fedora-directory-devel at redhat.com
>https://www.redhat.com/mailman/listinfo/fedora-directory-devel
>  
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3170 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.fedoraproject.org/pipermail/389-devel/attachments/20061025/babec578/attachment.bin