[389-devel] Please Review: Fix parsing of start-slapd scripts

[Noriko Hosoi]

On 04/01/2010 11:18 AM, Nathan Kinder wrote:
> On 03/31/2010 10:04 PM, Nathan Kinder wrote:
>> On 03/31/2010 09:52 PM, Endi Sukma Dewata wrote:
>>> ----- "Nathan Kinder"<nkinder at redhat.com>   wrote:
>>>
>>>
>>>>>> The admin server CGIs parse the start-slapd scripts to determine the
>>>>>> DS instance names.  A recent format change to start-slapd caused 
>>>>>> this
>>>>>> parsing to break.  These patches make the instance name easier to
>>>>>> parse from the script.  One patch is for DS itself and one is for 
>>>>>> the
>>>>>> Admin Server.
>>>>>>
>>>>>>
>>>>> ack - much better
>>>>>
>>>>>
>>>> Thanks, but I need to nak my own patch since it's imcomplete.
>>>>
>>>> This isn't going to work well when upgrading an instance.  We don't
>>>> regenerate the start-slapd script when running 'setup-ds.pl -u'.  This
>>>> means that an upgraded instance will not work properly with any of the
>>>> admin server CGIs that need to parse the instance name from
>>>> start-slapd.  This issue is already a problem not related to this 
>>>> patch,
>>>> but it seems we should fix it along with this issue.
>>>>
>>>> I suppose the right thing to do is to make 'setup-ds.pl -u' generate a
>>>> new start-slapd script for the existing instances as well as a new
>>>> instance specific initconfig script if one doesn't exist.  I think we
>>>> need to avoid wiping out an existing instance specific sysconfig 
>>>> script
>>>> since it may have been modified by an admin to add other stuff to it
>>>> (like KRB5_KTNAME for Kerberos).  Do you see any problems with this
>>>> approach?
> I've attached a new set of patches that implements the solution 
> outlined above.
ack.
--noriko

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6646 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.fedoraproject.org/pipermail/389-devel/attachments/20100401/5d5db665/attachment.bin