[389-devel] Please review: [Bug 171338] Enhancement: winsync modrdn not synced

[Noriko Hosoi]

[Bug 171338] Enhancement: winsync modrdn not synce

https://bugzilla.redhat.com/show_bug.cgi?id=171338

Problem Descriptions:
Rename (modrdn) with newsuperior has not been implemented on the RH/389 
DS.  Therefore, even if entries were moved on AD, WinSync could not 
synchronize the change on the DS.  Now, the functionality is being added 
to the DS.  Using it, the rename operation should be able to get 
synchronized.

Fix Descriptions:
windows_protocol_util.c:
1. Implemented process_replay_rename for DS --> AD rename (modrdn)
synchronization. It checks the new local superior and the current remote
superior. If they don't match, it calls windows_conn_send_rename. If the
entry is a user, the leaf RDN on AD is ntUserDomainId, which is not the leaf
RDN on DS. Thus, newrdn passed to windows_conn_send_rename is the leaf 
RDN of
AD, which won't be changed in this process_replay_rename. If the entry is a
group, the leaf RDN on AD is the same as the one on DS. Thus, newrdn is
passed to windows_conn_send_rename. If the rename on AD failed by
LDAP_NO_SUCH_OBJECT, the target entry might have been deleted on AD. To
recover the problem, add the renamed entry to AD.
2. Modified windows_update_local_entry to update the local entry if the 
rename
operation occurred on AD (AD --> DS). In the function, a code to check
the local and remote superiors is added. If they don't match, the local 
entry is
renamed. Similar to DS --> AD, the rename only takes care of newsuperior
change for a user; it could update both newrdn and newsuperior for a group.

windows_connection.c: fixed a typo

Proposed Fix:
https://bugzilla.redhat.com/attachment.cgi?id=385774&action=diff
git diff ldap/servers/plugins/replication/{windows_connection.c, 
windows_protocol_util.c}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6646 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.fedoraproject.org/pipermail/389-devel/attachments/20100120/441849ff/attachment.bin