[389-devel] Please review: fix several compiler warnings
Nathan Kinder
nkinder at redhat.com
Wed Sep 1 23:02:08 UTC 2010
On 09/01/2010 03:51 PM, Rich Megginson wrote:
> - "backend: %s \n", be->be_name, isglobal?"(global mode)":"");
> + "backend: %s%s%s\n", be->be_name, isglobal?" ":"", isglobal?"(global mode)":"");
Is there any reason that this section shouldn't just use 2 strings in
the format statement? Something like this:
"backend: %s%s\n", be->be_name, isglobal?" (global mode)":"");
Other than that minor nitpick, the changes look good.
-NGK
More information about the 389-devel
mailing list