[389-devel] Please review: Reduce the number of DN normalization
Noriko Hosoi
nhosoi at redhat.com
Mon Oct 10 17:08:19 UTC 2011
Reduce the number of DN normalization
. Replacing SLAPI_TARGET_DN with SLAPI_TARGET_SDN (also its macros,
e.g., SLAPI_SEARCH_TARGET_SDN and SLAPI_ADD_TARGET_SDN).
. Replacing the type of SLAPI_MODRDN_NEWSUPERIOR from (char *) to
(Slapi_DN *), as well.
. Replacing slapi_dn_normalization_ext call with generating Slapi_DN
APIs (e.g., slapi_sdn_new_dn_...) as much as possible and stash it
in pblock using SLAPI_TARGET_SDN.
. When a normalized DN string is needed, get it using slapi_sdn_get_[n]dn
from the stashed Slapi_DN.
. Introduced a new field to Slapi_DN.
"udn" for the original DN; "dn" is a normalized DN; "ndn" is a case-
ignored normalized DN.
Taking advantage of the knowledge of the stage of the DN, call the
most efficient DN creating API (e.g., slapi_sdn_new_dn_... vs.
slapi_sdn_new_normdn_... vs. slapi_sdn_new_ndn_...)
Others
. Replacing inefficient array assignment with memset (acl.c) and
memcpy (idl_common.c).
. Fixing invalid memory access in LASDnsBuild (lib/libaccess/lasdns.cpp).
. Even if Slapi_counter is disabled, the server is allowed to start
(back-ldbm/cache.c).
. Fixing compiler warnings.
Sorry, it's huge...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Reduce-the-number-of-DN-normalization.patch
Type: text/x-patch
Size: 454937 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/389-devel/attachments/20111010/e8cb37b5/attachment-0001.bin
More information about the 389-devel
mailing list