[389-devel] Please review: [389 Project] #547: [Patch] Incorrect assumption in ndn cache

Noriko Hosoi nhosoi at redhat.com
Tue Jan 8 01:21:24 UTC 2013


https://fedorahosted.org/389/ticket/547

https://fedorahosted.org/389/attachment/ticket/547/0001-Ticket-547-Incorrect-assumption-in-ndn-cache.patch

Bug Description: In ndn_cache_lookup, to determine the given dn
is already normalized or not, the length is compared with the
normalized dn length.  If they match, it considers the given dn
is already normalized.  But there are cases even if the lengths
are equal, the given dn may not be normalized yet.
(e.g., 'cn="o=ABC",o=XYZ' vs. 'cn=o\3DABC,o=XYZ')

Fix Description: This patch adds another check: if the dn and
normalized dn length match, call memcmp to compare the 2 dn's.
When memcmp returns 0, ndn_cache_lookup returns the passed dn.


More information about the 389-devel mailing list