[389-devel] Please review lib389 ticket 47584 (take #2): CI tests: add backup/restore of an instance

thierry bordaz tbordaz at redhat.com
Wed Nov 6 17:47:31 UTC 2013


Hi Roberto,

    Yes absolutely this is a better choice !! thanks for the tips, I
    will change the fix

regards
thierry

On 11/06/2013 06:35 PM, Roberto Polli wrote:
> You may consider replacing the whole function checkInstanceBackupFS
> with the simpler:
>   backup_pattern = os.path.join(backupDir, "backup*.tar.gz")
>   return glob.glob(backup_pattern)
>
> It should return an empty list in case of unexistent path
>
> On Wednesday 06 November 2013 18:31:40 thierry bordaz wrote:
>> Thanks Roberto and Rich for reviewing this.
>> This second patch takes into account your recommendation to let the
>> logging mechanism to choose rather that to use 'verbose' flag.
>>
>> https://fedorahosted.org/389/attachment/ticket/47584/0002-Ticket-47584-CI-te
>> sts-add-backup-restore-of-an-insta.patch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/389-devel/attachments/20131106/d1977a2c/attachment.html>


More information about the 389-devel mailing list