[fedora-arm] [PATCH] Possible fix for u-boot on wandboard

[Niels de Vos]

On Sat, Sep 21, 2013 at 09:18:35PM -0400, Steven Falco wrote:
> I've been looking into the reason why my wandboard would
> not boot Fedora reliably.  I would typically get one
> good boot every 3 or 4 tries.
> 
> It is late, and I need to stop now, but the following
> proposed patch to uboot allows my board to boot without
> errors, at least a dozen times in a row, which it has
> never done before.
> 
> Basically, cmdtp->name is not valid for some reason,
> so uboot goes off into the weeds.  I have not tracked
> down the explanation, but if anyone else would like to
> give this a try, I'd very much appreciate the feedback.

Oh, nice catch. That would explain why the garbage gets printed. I don't 
know yet when I have time to test this, but I'll add it on my TODO.

This patch would be a workaround and not a final solution. I guess 
->name should be set correctly somewhere, or other members of *cmdtp 
should not overwrite the pointer.

Anyway, it looks like you narrowed down the cause pretty much. Thanks, 
for sharing!

Niels


> 
> Signed-off-by: Steven A. Falco <stevenfalco at gmail.com>
> 
> --
> 
> diff -ur BUILD.original/u-boot-2013.07/common/cmd_bootm.c BUILD/u-boot-2013.07/common/cmd_bootm.c
> --- BUILD.original/u-boot-2013.07/common/cmd_bootm.c	2013-07-23 07:58:13.000000000 -0400
> +++ BUILD/u-boot-2013.07/common/cmd_bootm.c	2013-09-21 21:08:10.623374338 -0400
> @@ -997,7 +998,7 @@
>  		break;
>  #endif
>  	default:
> -		printf("Wrong Image Format for %s command\n", cmdtp->name);
> +		printf("Wrong Image Format for command\n");
>  		bootstage_error(BOOTSTAGE_ID_FIT_KERNEL_INFO);
>  		return NULL;
>  	}
> 
> 
> _______________________________________________
> arm mailing list
> arm at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/arm