mkisofs VolumeID 32 character limitation

[Joel Andres Granados]

Hi list:
still pocking at pungi...
Bug(I think): Pungi fails sometimes with a message that the mkisofs 
command failed.  On further investigation
      of the pungi log it seems that the label given to the iso is to 
long.  Looked at the mkisofs
      man page and found out that it only supports 32 characters in the 
iso label.  In my configuration
      it had a label of 33 "Fedora development x86_64 rescue"
Reason: There is a possibility for the cds iso images label to be Too 
long.  In the end the user
        defines the label because it is constructed from the pungi.conf 
variables:Prodcut_name, arch,
        version...
Possible fix: make sure to snip off the label before creating the 
isoimage.  With the patch I'm trying to cut the id to an allowable 
size.  Although I *do* cut the original name and I don't know what the 
effects are in the installations.  I did run pungi and it ended with no 
errors.
Comments: when the was shortened from the config file pungi executed 
successfully.  comments greatly appreciated.


The diff:
@@ -356,8 +359,8 @@
                         extraargs.append(os.path.join('%s-disc%s' % 
(self.topdir, disc), "ppc/mac"))
 
                 extraargs.append('-V')
-                extraargs.append('"%s %s %s Disc %s"' % 
(self.config.get('default', 'product_name'),
-                    self.config.get('default', 'version'), 
self.config.get('default', 'arch'), disc))
+                extraargs.append(('"%s %s %s Disc %s"' % 
(self.config.get('default', 'product_name'),
+                    self.config.get('default', 'version'), 
self.config.get('default', 'arch'), disc))[:32])
 
                 extraargs.append('-o')
                 extraargs.append(isofile)
@@ -417,8 +422,8 @@
                     extraargs.append(os.path.join('%s-disc%s' % 
(self.topdir, disc), "ppc/mac"))
 
             extraargs.append('-V')
-            extraargs.append('"%s %s %s DVD"' % 
(self.config.get('default', 'product_name'),
-                self.config.get('default', 'version'), 
self.config.get('default', 'arch')))
+            extraargs.append(('"%s %s %s DVD"' % 
(self.config.get('default', 'product_name'),
+                self.config.get('default', 'version'), 
self.config.get('default', 'arch')))[:32])
 
             extraargs.append('-o')
             extraargs.append(isofile)