[patch 1/4] Remove Python 2.5 usage
Toshio Kuratomi
a.badger at gmail.com
Fri Aug 31 16:24:17 UTC 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> An empty list of base classes wasn't allowed before Python 2.5 so
> remove it since it seems to be the only Python 2.5 feature being
> used.
What version of python are you taking as your minimum? If it's
python2.2 then you'd be better off inheriting from object. Inheriting
from object makes this a new-style class which has some features and
behaviors that can make it superior to old-style classes.
Revised patch:
Index: pungi/pypungi/__init__.py
===================================================================
- --- pungi.orig/pypungi/__init__.py
+++ pungi/pypungi/__init__.py
@@ -16,7 +16,7 @@ import logging
import os
import subprocess
- -class PungiBase():
+class PungiBase(object):
"""The base Pungi class. Set up config items and logging here"""
def __init__(self, config):
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFG2ECxX6yAic2E7kgRAsNfAJwJXRMOdu6HjYzqjGxPO6xXxMNVVgCfd8L0
c/wgEOGTft0e9/CuNbGmu0Q=
=JVoi
-----END PGP SIGNATURE-----
More information about the buildsys
mailing list