pungi logger

Jesse Keating jkeating at redhat.com
Tue May 15 18:20:29 UTC 2007


On Friday 04 May 2007 10:13:34 Joel Andres Granados wrote:
> Referring to ticket #34 at
> https://hosted.fedoraproject.org/projects/pungi/ticket/34 stating that
> the logger needed a little work so that it didn't depend on the
> gather.py (or at least thats what I understood :)  I propose either a
> new file (pungiLog.py) located in the pypungi directory or a new
> function in the "pungi" file that contains the logging stuff.  The log
> services would be started somewhere before the line containing "#
> Actually do work." of the "pungi" file.  The logging root would be
> called "pungi" and would be called in each file that logging is needed
> with the logging.getlogger("pungi") command.
> If "quiet" is specified in the config file the logging will be turned off.
>
> *Diff for the pungi file:*
> 1. Initializes the logger by calling to the new file.
> 2. specify quiet value.
> 3.  logging function.
> *
> Diff for pungi.py file:
> *1. use the correct logger.
> *
> Diff for gather.py file:*
> change all the if statements for each logging call.
>
> Files attached...
> Comments appreciated.

Thanks for this.  I think this is the right direction.  However I'm reluctant 
to make such a change this late in Fedora 7 development.  I'll want to look 
at this once I start doing Fedora 8 changes.

-- 
Jesse Keating
Release Engineer: Fedora
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/buildsys/attachments/20070515/5ccb4543/attachment.bin 


More information about the buildsys mailing list