[PATCH 2/3] Do not build binary packages with --nodeps.
Dennis Gilmore
dennis at ausil.us
Thu Oct 21 21:33:37 UTC 2010
On Wed, Oct 20, 2010 at 11:04:19PM +0300, Ville Skyttä wrote:
> Not sure why it was done in the first place; maybe because of
> fragility of resolvedep screen-scraping? We no longer do that.
> ---
> py/mock/backend.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/py/mock/backend.py b/py/mock/backend.py
> index 81a98d0..4ad5963 100644
> --- a/py/mock/backend.py
> +++ b/py/mock/backend.py
> @@ -531,7 +531,7 @@ class Root(object):
> self._callHooks('prebuild')
>
> self.doChroot(
> - ["bash", "--login", "-c", 'rpmbuild -bb --target %s --nodeps %s' % (self.rpmbuild_arch, chrootspec)],
> + ["bash", "--login", "-c", 'rpmbuild -bb --target %s %s' % (self.rpmbuild_arch, chrootspec)],
> shell=False,
> logger=self.build_log, timeout=timeout,
> uid=self.chrootuid,
> --
> 1.7.2.3
its done because you cant trust that the rpm in the chroot can access
the rpm database that was created by the hosts rpm.
-1 to this patch
Dennis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/buildsys/attachments/20101021/a1c81b3e/attachment.bin
More information about the buildsys
mailing list