[PATCH] Allow spec file to be in a different path than /

Mathieu Bridon bochecha at fedoraproject.org
Thu Aug 7 08:01:09 UTC 2014


Disclaimer: I'm not a Koji maintainer

On Wed, 2014-08-06 at 17:42 +0200, Thomas wrote:
> +                    # check if spec path is defined
> +                    if len(scm_tuple) >= 5:
> +                        if scm_tuple[4]:
> +                            self.spec_path = scm_tuple[4] + '/'

Not commenting on whether this is desired or acceptable, but if you're
adding a new part to the allowed_scms tuple, could you also document it
in the kojid.conf file, to help admins know about this parameter?

Right now there already is an undocumented option (source_cmd) which
admins can only discover by reading the source code. I just sent a patch
to fix that, but it would be nice if we didn't add one more undocumented
option. :)


-- 
Mathieu



More information about the buildsys mailing list