[PATCH 5/5] put disttag in mockbuild results directory name

Mathieu Bridon bochecha at fedoraproject.org
Mon Sep 8 07:57:22 UTC 2014


Note: I'm not an rpkg maintainer, just an occasional contributor. ;)


On Sat, 2014-09-06 at 20:25 -0700, Lars R. Damerow wrote:
> From: "Lars R. Damerow" <lars at pixar.com>
> 
> This patch stops multiple mockbuild runs for different distributions
> from clobbering each other.
> ---
>  src/pyrpkg/__init__.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/pyrpkg/__init__.py b/src/pyrpkg/__init__.py
> index 2908c22..4bd5b86 100644
> --- a/src/pyrpkg/__init__.py
> +++ b/src/pyrpkg/__init__.py
> @@ -2149,7 +2149,7 @@ class Commands(object):
>                  cmd.extend(['--configdir', config_dir])
>  
>          cmd.extend(['-r', root, '--resultdir',
> -                    os.path.join(self.path, "results_%s" % self.module_name,
> +                    os.path.join(self.path, "results_%s_%s" % (self.module_name, self.disttag),

Isn't the disttag already part of the results dir tree?

    results_%(name)s/%(version)s/%(release)s/

And the release includes the dist (well, unless it hasn't been set in
the spec file...)

This changes where the results are though (they aren't all in the same
results_%(name)s folder any more), which might break some expectations?

Maybe this specific change should really be in your rpkg-based tool?


-- 
Mathieu



More information about the buildsys mailing list