[PATCH 5/5] put disttag in mockbuild results directory name

[Pavol Babincak]

On 09/08/2014 08:21 PM, Lars R. Damerow wrote:
> From Mathieu Bridon <bochecha at fedoraproject.org>, Mon, Sep 08, 2014
> at 09:57:22AM +0200:
>> On Sat, 2014-09-06 at 20:25 -0700, Lars R. Damerow wrote:
>>> From: "Lars R. Damerow" <lars at pixar.com>
>>> 
>>> This patch stops multiple mockbuild runs for different
>>> distributions from clobbering each other.
>> 
>> Isn't the disttag already part of the results dir tree?
>> 
>> results_%(name)s/%(version)s/%(release)s/
>> 
>> And the release includes the dist (well, unless it hasn't been set
>> in the spec file...)
> 
> We have lots of old packages that don't include the dist in the
> release.
> 
>> This changes where the results are though (they aren't all in the
>> same results_%(name)s folder any more), which might break some
>> expectations?
>> 
>> Maybe this specific change should really be in your rpkg-based
>> tool?
> 
> That's fine with me. The only complication is that this line is in
> the middle of a fair bit of code, so I'd have to replicate the whole
> function in my derived class. How about I factor it into its own
> function call (Commands._set_result_dir()?) that can be easily
> overridden?
I don't want to change this directory structure for every pyrpkg's
clients (including fedpkg). I went ahead and refactored this directory
name to separate @property which you can easily override in your code:
https://git.fedorahosted.org/cgit/rpkg.git/commit/?id=a629482569d46d62441b6d161747be5ed7be510e
-- 
Pavol Babincak
Release Engineering, Red Hat