[PATCH] Don't enable by default

Colin Walters walters at verbum.org
Wed Jul 16 22:21:26 UTC 2014


On Tue, Jul 15, 2014, at 02:52 AM, Garrett Holmstrom wrote:

> This would be a great thing to add to the bug report for this issue [1] 
> as well.

Done, patch attached.

> If the kickstart explicitly enables cloud-init then yes, let's drop the 
> self-enabling bits.  We should really be using per-product service 
> presets for that instead; I suppose I should work on a policy for that 
> [2] now that it is finally clear which packages those belong in.  8^)

I think we're OK with the kickstart file enabling the services.  I
tested
an upgrade from F20 works, which it would as you'd expect, because
nothing is going to touch the existing links in
/etc/.../multi-user.wants.d.

I didn't test a fresh ImageFactory compose as my main laptop is
RHEL7 and it isn't yet packaged for that.  (Though I am investigating
running these types of tools out of mock or Docker containers, it's
just ugly as ImageFactory requires virt)

> Please remove .atomic from the release tag.  The spec file will also 
> need to use %systemd_post and %systemd_postun in addition to 
> %systemd_preun if we're to follow the packaging guidelines [3].

Fixed both, thanks.


More information about the cloud mailing list