[Bug 226377] Merge Review: rpm

[Axel Thimm]

On Fri, Aug 24, 2007 at 11:44:36PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > I think rpm5 in Fedora is dangerous. At the very least it reverses
> > the ordering of letters and digits and thus breaks a ton of packaging
> > techniques. Any *-1.fc8 -> *.1.1.fc8 upgrade path is busted for
> > example.
> 
> Are you 100% sure? I've seen Jeff deny this on IRC.

Index: rpmvercmp.c
===================================================================
RCS file: /cvs/devel/rpm/lib/rpmvercmp.c,v
retrieving revision 2.8.2.2
diff -u -b -B -w -p -r2.8.2.2 rpmvercmp.c
--- rpmvercmp.c 27 Aug 2006 12:58:19 -0000      2.8.2.2
+++ rpmvercmp.c 26 Apr 2007 22:36:26 -0000
@@ -76,7 +76,7 @@ int _rpmvercmp(const char * a, const cha
         /* different types: one numeric, the other alpha (i.e.  
empty) */
         /* numeric segments are always newer than alpha segments */
         /* XXX See patch #60884 (and details) from bugzilla
	 #50977. */
-       if (two == str2) return (isnum ? 1 : -1);
+       if (two == str2) return (isnum ? -1 : 1);
         if (isnum) {
             /* this used to be done by converting the digit segments
	     */
-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/advisory-board/attachments/20070825/c4f808f0/attachment.bin