[PATCH] Makefile.common: bodhi update target

Nils Philippsen nphilipp at redhat.com
Tue Nov 13 16:44:49 UTC 2007


On Mon, 2007-11-12 at 13:01 -0500, Luke Macken wrote:
> Attached is a patch to add an 'update' target to our common Makefile.
> When executed in a branch supported by bodhi (F-{7,8}), it will drop
> you into a template and then submit your update to bodhi.
> 
> Comments/suggestions welcome,

There's one thing I'd rather have changed before this gets live:

"To abort this update, delete any uncommented lines before saving this
file"

"make update/bodhi" should rather write the template into 2 files
(bodhi.template, bodhi.template.unchanged?), run the editor on one of
them and only commit if both files differ and contain non-comment lines.
That way it would behave like "all VCSes known to man" (i.e. me).

Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp at redhat.com
"Those who would give up Essential Liberty to purchase a little Temporary
 Safety, deserve neither Liberty nor Safety."  --  B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011




More information about the devel mailing list