fedpkg local redefines %fedora macro

[Dennis Gilmore]

On Monday, August 09, 2010 04:27:31 pm Kyle VanderBeek wrote:
> That would
certainly explain all the problems I've been having getting
> python3
packages built with "fedpkg local".  All of my "%if
> 0%{?fedora} > 12"
lines would blow up.
> 
> On Mon, Aug 9, 2010 at 6:54 AM, Petr Pisar
<ppisar at redhat.com> wrote:
> > Hello,
> > 
> > while working on `nas'
package I found `fedpkg local' redefines
> > `fedora' macro to value `1'.
Dist-cvs `make local' does not do that.
> > Original source for %fedora is
/etc/rpm/macros.dist. See the strace:
> > 
> > $ strace -fqv -eexecve fedpkg
local
> > [...]
> > execve("/bin/rpm", ["rpm", "--define", "_sourcedir
> >
/home/petr/fedora/nas", "--define", "_specdir /home/petr/fedora/nas",
> >
"--define", "_builddir /home/petr/fedora/nas", "--define", "_srcrpmdir
> >
/home/petr/fedora/nas", "--define", "_rpmdir /home/petr/fedora/nas",
> >
"--define", "dist .fc15", "--define", "fedora 15", "--define", "fedora
> >
1", "-q", "--qf", "%{VERSION} ", "--specfile",
> >
"/home/petr/fedora/nas/nas.spec"],...)
> > 
> > You can check it with this
simple spec file:
> > 
> > %if 0%{?fedora} > 8
> >    echo TRUE %{?fedora}
>
> %else
> >    echo FALSE %{?fedora}
> > %endif
> > 
> > -- Petr
> > 
The
latest build in koji does the right thing. I need to push it out as an
update

Dennis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://lists.fedoraproject.org/pipermail/devel/attachments/20100809/c92e9650/attachment.bin