LD Changes To Implicit DSO Linking Update

[Michael Schwendt]

On Tue, 9 Feb 2010 23:28:01 +0530, Parag wrote:

> On Tue, Feb 9, 2010 at 11:18 PM, Jakub Jelinek <jakub at redhat.com> wrote:
> > On Tue, Feb 09, 2010 at 11:09:50PM +0530, Parag N(पराग़) wrote:
> >>  Anyway I find adding missing DSO to CFLAGS in SPEC is easy solution for now.
> >
> > They don't belong to CFLAGS, those are flags for compilation.  You want
> > LDFLAGS or even better add it in configure to LIBS.
> 
>   I am not sure then what's wrong with my package. Here is how it
> failed http://koji.fedoraproject.org/koji/getfile?taskID=1970866&name=build.log
> and then modifying CFLAGS its successful build at
> http://kojipkgs.fedoraproject.org/packages/iok/1.3.9/1.fc13/data/logs/i686/build.log
>

Replace
  make CFLAGS="%{optflags} -X11" %{?_smp_mflags}
with
  make CFLAGS="%{optflags}" LDFLAGS="-lX11" %{?_smp_mflags}