Sources file audit - 2010-01-06

[Christopher Brown]

2010/1/10 Kevin Fenzi <kevin at scrye.com>:
> On Sun, 10 Jan 2010 18:42:41 +0000
> Christopher Brown <snecklifter at gmail.com> wrote:
>
>> Which I have done for jokosher unless this means I have to drop the
>> bzr suffix?
>
> You have:
>
> Source0: http://www.%{name}.org/downloads/source/%{name}-20091128bzr.tar.gz
>
> That URL is 404. There is no file with that URI.
>
> You should have (IMHO):
>
> # The source for this package was pulled from upstream's vcs.  Use the
> # following commands to generate the tarball:
> #  <bzr command that checks out that exact revision>
> #  tar -czvf foo-20091129bzr.tar.gz foo-20001128
>
> Source0: %{name}-20091228bzr.tar.gz
>
> You should not make up a URL to a nonexistent file.
> Just explain in a comment how exactly someone would duplicate your
> source file using bzr and tar, and drop the http:// part of the Source.
>
> Does that make sense?

It does, thanks.

-- 
Christopher Brown