[PATCH] macros: Globally add --disable-silent-rules to configure

Jan Kratochvil jan.kratochvil at redhat.com
Tue Aug 9 17:34:48 UTC 2011


On Tue, 09 Aug 2011 19:16:54 +0200, Matthew Garrett wrote:
> Never, ever ship software with -Werror enabled.

I agree - for source distribution.  Yes, GDB releases have -Werror turned off.


> It's a development-only 
> option. You have no idea what gcc will decide is a warning in future, so 
> it's effectively a "Please break my build in six months" toggle.

I believe -Werror is appropriate for .src.rpm as only .arch.rpm is what is
being shipped to the real users.  -Werror is only of concern to the package
maintainer who should keep warnings under control.  -Werror is probably the
most easy way to keep them non-regressing.

One can only argue -Werror is not appropriate for rpmbuild --rebuild by users.
But they will see new warnings only in non-standardard
distro/environment/configuration, such advanced users should be aware of
everything how to deal with it anyway.


Thanks,
Jan


More information about the devel mailing list