systemd: Tagging /dev/virtio-ports/* for systemd

Richard W.M. Jones rjones at redhat.com
Wed Jul 6 13:35:44 UTC 2011


On Wed, Jul 06, 2011 at 02:35:13PM +0200, Lennart Poettering wrote:
> Wouldn't it make sense to fix the daemon to return EXIT_SUCCESS in those
> legitimate-ish cases?

It's probably just me but I find code that does this slightly
repugnant:

  if (some_syscall() == -1) {
    perror ("some_syscall");
    exit (EXIT_SUCCESS);
  }

There are a large number of places in the code which we would need to
examine and possibly change.

I think as long as systemd is doing rate-limiting, we should be fine.
The daemon is heavily tested anyway and hasn't so far failed at
start-up time ...

Anyway, I'm going to test it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


More information about the devel mailing list